From 5171605a8c054f5bf99d0ae1e8c0ee22c38698fb Mon Sep 17 00:00:00 2001
From: Daniel Spaude <daniel@spaude.de>
Date: Tue, 27 Dec 2022 12:01:44 +0100
Subject: [PATCH] qr scanner - WIP - adapt qr code generator options so they
 are recognized by the scanner

---
 .../nc-gui/components/virtual-cell/QrCode.vue | 15 +++++++++++++++
 packages/nc-gui/package-lock.json             | 19 +++++++++++++++++++
 packages/nc-gui/package.json                  |  1 +
 3 files changed, 35 insertions(+)

diff --git a/packages/nc-gui/components/virtual-cell/QrCode.vue b/packages/nc-gui/components/virtual-cell/QrCode.vue
index b030d24c5f..f33eaa0701 100644
--- a/packages/nc-gui/components/virtual-cell/QrCode.vue
+++ b/packages/nc-gui/components/virtual-cell/QrCode.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import { useQRCode } from '@vueuse/integrations/useQRCode'
+import type QRCode from 'qrcode'
 
 const maxNumberOfAllowedCharsForQrValue = 2000
 
@@ -11,11 +12,25 @@ const tooManyCharsForQrCode = computed(() => qrValue?.value.length > maxNumberOf
 
 const showQrCode = computed(() => qrValue?.value?.length > 0 && !tooManyCharsForQrCode.value)
 
+const qrCodeOptions: QRCode.QRCodeToDataURLOptions = {
+  errorCorrectionLevel: 'M',
+  // type: 'image/png',
+  // quality: 0.92,
+  margin: 1,
+  version: 4,
+  rendererOpts: {
+    quality: 1,
+  },
+}
+console.log(qrCodeOptions)
+
 const qrCode = useQRCode(qrValue, {
+  ...qrCodeOptions,
   width: 150,
 })
 
 const qrCodeLarge = useQRCode(qrValue, {
+  ...qrCodeOptions,
   width: 600,
 })
 
diff --git a/packages/nc-gui/package-lock.json b/packages/nc-gui/package-lock.json
index d36ae912a6..1f454de5f7 100644
--- a/packages/nc-gui/package-lock.json
+++ b/packages/nc-gui/package-lock.json
@@ -70,6 +70,7 @@
         "@types/axios": "^0.14.0",
         "@types/dagre": "^0.7.48",
         "@types/papaparse": "^5.3.2",
+        "@types/qrcode": "^1.5.0",
         "@types/sortablejs": "^1.13.0",
         "@types/tinycolor2": "^1.4.3",
         "@types/validator": "^13.7.10",
@@ -3154,6 +3155,15 @@
         "@types/node": "*"
       }
     },
+    "node_modules/@types/qrcode": {
+      "version": "1.5.0",
+      "resolved": "https://registry.npmjs.org/@types/qrcode/-/qrcode-1.5.0.tgz",
+      "integrity": "sha512-x5ilHXRxUPIMfjtM+1vf/GPTRWZ81nqscursm5gMznJeK9M0YnZ1c3bEvRLQ0zSSgedLx1J6MGL231ObQGGhaA==",
+      "dev": true,
+      "dependencies": {
+        "@types/node": "*"
+      }
+    },
     "node_modules/@types/qs": {
       "version": "6.9.7",
       "resolved": "https://registry.npmjs.org/@types/qs/-/qs-6.9.7.tgz",
@@ -20247,6 +20257,15 @@
         "@types/node": "*"
       }
     },
+    "@types/qrcode": {
+      "version": "1.5.0",
+      "resolved": "https://registry.npmjs.org/@types/qrcode/-/qrcode-1.5.0.tgz",
+      "integrity": "sha512-x5ilHXRxUPIMfjtM+1vf/GPTRWZ81nqscursm5gMznJeK9M0YnZ1c3bEvRLQ0zSSgedLx1J6MGL231ObQGGhaA==",
+      "dev": true,
+      "requires": {
+        "@types/node": "*"
+      }
+    },
     "@types/qs": {
       "version": "6.9.7",
       "resolved": "https://registry.npmjs.org/@types/qs/-/qs-6.9.7.tgz",
diff --git a/packages/nc-gui/package.json b/packages/nc-gui/package.json
index 5fb880206b..a8f601764c 100644
--- a/packages/nc-gui/package.json
+++ b/packages/nc-gui/package.json
@@ -93,6 +93,7 @@
     "@types/axios": "^0.14.0",
     "@types/dagre": "^0.7.48",
     "@types/papaparse": "^5.3.2",
+    "@types/qrcode": "^1.5.0",
     "@types/sortablejs": "^1.13.0",
     "@types/tinycolor2": "^1.4.3",
     "@types/validator": "^13.7.10",