refactor(nocodb): pr comments

2 years ago · 4f1f49e660
3 changed files with 14 additions and 6 deletions
--- a/packages/nocodb/src/lib/meta/api/swagger/redocHtml.ts
+++ b/packages/nocodb/src/lib/meta/api/swagger/redocHtml.ts
@ -1,4 +1,8 @@
-export default (ncSiteUrl: string): string => `<!DOCTYPE html>
+export default ({
+  ncSiteUrl,
+}: {
+  ncSiteUrl: string;
+}): string => `<!DOCTYPE html>
 <html>
 <head>
    <title>NocoDB API Documentation</title>
--- a/packages/nocodb/src/lib/meta/api/swagger/swaggerApis.ts
+++ b/packages/nocodb/src/lib/meta/api/swagger/swaggerApis.ts
@ -38,12 +38,12 @@ async function swaggerJson(req, res) {
  res.json(swagger);
 }

-function swaggerHtml(req, res) {
-  res.send(getSwaggerHtml(req.ncSiteUrl));
+function swaggerHtml(_, res) {
+  res.send(getSwaggerHtml({ ncSiteUrl: process.env.NC_PUBLIC_URL || '' }));
 }

-function redocHtml(req, res) {
-  res.send(getRedocHtml(req.ncSiteUrl));
+function redocHtml(_, res) {
+  res.send(getRedocHtml({ ncSiteUrl: process.env.NC_PUBLIC_URL || '' }));
 }

 const router = Router({ mergeParams: true });
--- a/packages/nocodb/src/lib/meta/api/swagger/swaggerHtml.ts
+++ b/packages/nocodb/src/lib/meta/api/swagger/swaggerHtml.ts
@ -1,4 +1,8 @@
-export default (ncSiteUrl: string): string => `<!DOCTYPE html>
+export default ({
+  ncSiteUrl,
+}: {
+  ncSiteUrl: string;
+}): string => `<!DOCTYPE html>
 <html>
 <head>
    <title>NocoDB : API Docs</title>