From 4edee65b8ee4bd4cdaff7e4d6f2e7a69e3ae745f Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Sat, 16 Sep 2023 13:45:18 +0530
Subject: [PATCH] fix: avoid unwanted api calls

---
 packages/nc-gui/components/cell/Checkbox.vue                  | 4 ++--
 packages/nc-gui/components/virtual-cell/Links.vue             | 4 +++-
 .../nc-gui/components/virtual-cell/components/ListItem.vue    | 2 +-
 .../nc-gui/components/virtual-cell/components/ListItems.vue   | 2 +-
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/cell/Checkbox.vue b/packages/nc-gui/components/cell/Checkbox.vue
index 6791507382..bab7742ebb 100644
--- a/packages/nc-gui/components/cell/Checkbox.vue
+++ b/packages/nc-gui/components/cell/Checkbox.vue
@@ -78,7 +78,7 @@ useSelectedCellKeyupListener(active, (e) => {
 
 <template>
   <div
-    class="flex cursor-pointer w-full h-full py-1"
+    class="flex cursor-pointer w-full h-full"
     :class="{
       'justify-center': !isForm,
       'w-full': isForm,
@@ -92,7 +92,7 @@ useSelectedCellKeyupListener(active, (e) => {
       :class="{ '!ml-[-8px]': readOnly, 'w-full justify-start': isEditColumnMenu }"
       @click="onClick(true)"
     >
-      <div class="p-1" :class="{ 'bg-gray-100 rounded-full ': !vModel }">
+      <div :class="{ 'bg-gray-100 rounded-full ': !vModel }">
         <Transition name="layout" mode="out-in" :duration="100">
           <component
             :is="getMdiIcon(vModel ? checkboxMeta.icon.checked : checkboxMeta.icon.unchecked)"
diff --git a/packages/nc-gui/components/virtual-cell/Links.vue b/packages/nc-gui/components/virtual-cell/Links.vue
index 410575fecf..0d10f54196 100644
--- a/packages/nc-gui/components/virtual-cell/Links.vue
+++ b/packages/nc-gui/components/virtual-cell/Links.vue
@@ -46,7 +46,9 @@ loadRelatedTableMeta()
 
 const textVal = computed(() => {
   if (isForm?.value) {
-    return state.value?.[colTitle.value]?.length ? `${state.value?.[colTitle.value]?.length} records Linked` : 'No records linked'
+    return state.value?.[colTitle.value]?.length
+      ? `${+state.value?.[colTitle.value]?.length} records Linked`
+      : 'No records linked'
   }
 
   const parsedValue = +value?.value || 0
diff --git a/packages/nc-gui/components/virtual-cell/components/ListItem.vue b/packages/nc-gui/components/virtual-cell/components/ListItem.vue
index f3b6d76b4e..3d1b717925 100644
--- a/packages/nc-gui/components/virtual-cell/components/ListItem.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ListItem.vue
@@ -88,7 +88,7 @@ const attachments: Attachment[] = computed(() => {
           />
         </div>
 
-        <div v-if="fields.length > 0 && !isPublic" class="flex flex-row gap-4 w-10/12">
+        <div v-if="fields.length > 0 && !isPublic && !isForm" class="flex flex-row gap-4 w-10/12">
           <div v-for="field in fields" :key="field.id" :class="attachment ? 'w-1/3' : 'w-1/4'">
             <div class="flex flex-col gap-[-1] max-w-72">
               <LazySmartsheetHeaderVirtualCell
diff --git a/packages/nc-gui/components/virtual-cell/components/ListItems.vue b/packages/nc-gui/components/virtual-cell/components/ListItems.vue
index 60da204c7e..f4273c1e09 100644
--- a/packages/nc-gui/components/virtual-cell/components/ListItems.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ListItems.vue
@@ -79,7 +79,7 @@ watch(vModel, (nextVal, prevVal) => {
     /** reset query and limit */
     childrenExcludedListPagination.query = ''
     childrenExcludedListPagination.page = 1
-    if (!isForm) {
+    if (!isForm.value) {
       loadChildrenList()
     }
     loadChildrenExcludedList()