Browse Source

fix: typo in PR Docker Build message

pull/2648/head
Wing-Kam Wong 2 years ago
parent
commit
47d0a68bc5
  1. 2
      .github/workflows/release-pr.yml
  2. 2
      packages/noco-docs/content/en/engineering/builds-and-releases.md

2
.github/workflows/release-pr.yml

@ -84,7 +84,7 @@ jobs:
- uses: peter-evans/commit-comment@v2 - uses: peter-evans/commit-comment@v2
with: with:
body: | body: |
The PR changes have been deployed. Pleae run the following command to verify: The PR changes have been deployed. Please run the following command to verify:
``` ```
docker run -d -p 8888:8080 nocodb/nocodb-timely:${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }} docker run -d -p 8888:8080 nocodb/nocodb-timely:${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }}
``` ```

2
packages/noco-docs/content/en/engineering/builds-and-releases.md

@ -23,7 +23,7 @@ When a non-draft Pull Request is created, reopened or synchronized, a timely bui
The docker images will be built and pushed to Docker Hub (See [nocodb/nocodb-timely](https://hub.docker.com/r/nocodb/nocodb-timely/tags) for the full list). Once the image is ready, Github bot will add a comment with the command in the pull request. The tag would be `<NOCODB_CURRENT_VERSION>-pr-<PR_NUMBER>-<YYYYMMDD>-<HHMM>`. The docker images will be built and pushed to Docker Hub (See [nocodb/nocodb-timely](https://hub.docker.com/r/nocodb/nocodb-timely/tags) for the full list). Once the image is ready, Github bot will add a comment with the command in the pull request. The tag would be `<NOCODB_CURRENT_VERSION>-pr-<PR_NUMBER>-<YYYYMMDD>-<HHMM>`.
![image](https://user-images.githubusercontent.com/35857179/175012097-240dab05-da93-4c4e-87c1-1c36fb1350bd.png) ![image](https://user-images.githubusercontent.com/35857179/178413534-84b29afb-7a52-437b-a5df-b842b397390b.png)
## Executables ## Executables

Loading…
Cancel
Save