From 46ca3f0fb90617cfab31430992e3b493dbca23c5 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Mon, 25 Nov 2024 16:32:54 +0000
Subject: [PATCH] fix(nc-gui): use same char set for import & export csv

---
 .../nc-gui/extensions/data-exporter/index.vue | 24 ++++---------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/packages/nc-gui/extensions/data-exporter/index.vue b/packages/nc-gui/extensions/data-exporter/index.vue
index 385dfd634b..22e8761e86 100644
--- a/packages/nc-gui/extensions/data-exporter/index.vue
+++ b/packages/nc-gui/extensions/data-exporter/index.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import dayjs from 'dayjs'
-import { type ViewType, ViewTypes } from 'nocodb-sdk'
+import { charsetOptions, SupportedExportCharset, type ViewType, ViewTypes } from 'nocodb-sdk'
 
 const jobStatusTooltip = {
   [JobStatus.COMPLETED]: 'Export successful',
@@ -26,20 +26,6 @@ const delimiters = [
   },
 ]
 
-const encodings = [
-  { label: 'ASCII', value: 'ascii' },
-  { label: 'UTF-8', value: 'utf8' },
-  { label: 'UTF-8 with hyphen', value: 'utf-8' },
-  { label: 'UTF-16 LE', value: 'utf16le' },
-  { label: 'UCS-2', value: 'ucs2' },
-  { label: 'UCS-2 with hyphen', value: 'ucs-2' },
-  { label: 'Base64', value: 'base64' },
-  { label: 'Base64 URL', value: 'base64url' },
-  { label: 'Latin-1', value: 'latin1' },
-  { label: 'Binary', value: 'binary' },
-  { label: 'Hexadecimal', value: 'hex' },
-]
-
 const { $api, $poller } = useNuxtApp()
 
 const { appInfo } = useGlobal()
@@ -94,10 +80,10 @@ const exportPayload = ref<{
   tableId?: string
   viewId?: string
   delimiter?: string
-  encoding?: BufferEncoding
+  encoding?: SupportedExportCharset
 }>({
   delimiter: ',',
-  encoding: 'utf8',
+  encoding: SupportedExportCharset['utf-8'],
 })
 
 const tableList = computed(() => {
@@ -282,7 +268,7 @@ eventBus.on(async (event, payload) => {
 onMounted(async () => {
   exportPayload.value = extension.value.kvStore.get('exportPayload') || {}
   exportPayload.value.delimiter = exportPayload.value.delimiter || ','
-  exportPayload.value.encoding = exportPayload.value.encoding || 'utf-8'
+  exportPayload.value.encoding = exportPayload.value.encoding || SupportedExportCharset['utf-8']
 
   deletedExports.value = extension.value.kvStore.get('deletedExports') || []
 
@@ -460,7 +446,7 @@ onMounted(async () => {
                 dropdown-class-name="w-[190px]"
                 @change="saveChanges"
               >
-                <a-select-option v-for="encoding of encodings" :key="encoding.value" :value="encoding.value">
+                <a-select-option v-for="encoding of charsetOptions" :key="encoding.value" :value="encoding.value">
                   <div class="w-full flex items-center gap-2">
                     <NcTooltip class="flex-1 truncate" show-on-truncate-only>
                       <template #title>{{ encoding.label }}</template>