From 44d041ee3dea6a77c207dd5d83e624a1493a6412 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 19 Jun 2023 13:56:12 +0530
Subject: [PATCH] refactor: show column icon Lookup and Rollup

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../components/smartsheet/column/LookupOptions.vue       | 9 ++++++++-
 .../components/smartsheet/column/RollupOptions.vue       | 7 +++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/packages/nc-gui/components/smartsheet/column/LookupOptions.vue b/packages/nc-gui/components/smartsheet/column/LookupOptions.vue
index 5647459141..a97d4bfc96 100644
--- a/packages/nc-gui/components/smartsheet/column/LookupOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/LookupOptions.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { onMounted } from '@vue/runtime-core'
 import type { ColumnType, LinkToAnotherRecordType, TableType } from 'nocodb-sdk'
-import { isLinksOrLTAR, isSystemColumn } from 'nocodb-sdk'
+import { isLinksOrLTAR, isSystemColumn, isVirtualCol } from 'nocodb-sdk'
 import { getRelationName } from './utils'
 import { MetaInj, inject, ref, storeToRefs, useColumnCreateStoreOrThrow, useMetas, useProject, useVModel } from '#imports'
 
@@ -64,6 +64,12 @@ const onRelationColChange = () => {
   vModel.value.fk_lookup_column_id = columns?.[0]?.id
   onDataTypeChange()
 }
+
+
+const cellIcon = (column: ColumnType) =>
+  h(isVirtualCol(column) ? resolveComponent('SmartsheetHeaderVirtualCellIcon') : resolveComponent('SmartsheetHeaderCellIcon'), {
+    columnMeta: column,
+  })
 </script>
 
 <template>
@@ -94,6 +100,7 @@ const onRelationColChange = () => {
           @change="onDataTypeChange"
         >
           <a-select-option v-for="(column, index) of columns" :key="index" :value="column.id">
+            <component :is="cellIcon(column)" :column-meta="column" />
             {{ column.title }}
           </a-select-option>
         </a-select>
diff --git a/packages/nc-gui/components/smartsheet/column/RollupOptions.vue b/packages/nc-gui/components/smartsheet/column/RollupOptions.vue
index d077fff692..ad2215ad89 100644
--- a/packages/nc-gui/components/smartsheet/column/RollupOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/RollupOptions.vue
@@ -84,6 +84,11 @@ const onRelationColChange = () => {
   vModel.value.fk_rollup_column_id = columns?.[0]?.id
   onDataTypeChange()
 }
+
+const cellIcon = (column: ColumnType) =>
+  h(isVirtualCol(column) ? resolveComponent('SmartsheetHeaderVirtualCellIcon') : resolveComponent('SmartsheetHeaderCellIcon'), {
+    columnMeta: column,
+  })
 </script>
 
 <template>
@@ -114,6 +119,8 @@ const onRelationColChange = () => {
           @change="onDataTypeChange"
         >
           <a-select-option v-for="(column, index) of columns" :key="index" :value="column.id">
+            <component :is="cellIcon(column)" :column-meta="column" />
+
             {{ column.title }}
           </a-select-option>
         </a-select>