Browse Source

fix: replace computeAsync with custom watch to avoid unnecessary formula helper functions

pull/9662/head
Pranav C 1 month ago
parent
commit
4471bab718
  1. 37
      packages/nc-gui/components/smartsheet/column/FormulaOptions.vue

37
packages/nc-gui/components/smartsheet/column/FormulaOptions.vue

@ -85,23 +85,30 @@ if ((column.value?.colOptions as any)?.formula_raw) {
const source = computed(() => activeBase.value?.sources?.find((s) => s.id === meta.value?.source_id)) const source = computed(() => activeBase.value?.sources?.find((s) => s.id === meta.value?.source_id))
const parsedTree = computedAsync(async () => { const parsedTree = ref({
try { dataType: FormulaDataTypes.UNKNOWN,
const parsed = await validateFormulaAndExtractTreeWithType({
formula: vModel.value.formula || vModel.value.formula_raw,
columns: meta.value?.columns || [],
column: column.value ?? undefined,
clientOrSqlUi: source.value?.type as any,
getMeta: async (modelId) => await getMeta(modelId),
})
return parsed
} catch (e) {
return {
dataType: FormulaDataTypes.UNKNOWN,
}
}
}) })
watch(
() => vModel.value.formula || vModel.value.formula_raw,
async () => {
try {
const parsed = await validateFormulaAndExtractTreeWithType({
formula: vModel.value.formula || vModel.value.formula_raw,
columns: (meta.value?.columns || []).slice(),
column: column.value ? { ...column.value } : undefined,
clientOrSqlUi: source.value?.type as any,
getMeta: async (modelId) => await getMeta(modelId),
})
parsedTree.value = parsed
} catch (e) {
parsedTree.value = {
dataType: FormulaDataTypes.UNKNOWN,
}
}
},
)
// set additional validations // set additional validations
setAdditionalValidations({ setAdditionalValidations({
...validators, ...validators,

Loading…
Cancel
Save