From eb6972ee641c0fb479b745fc2a9b23eadbe55e8e Mon Sep 17 00:00:00 2001 From: Pranav C Date: Thu, 16 Feb 2023 12:51:23 +0530 Subject: [PATCH 1/8] refactor(gui): change dropdown icon with arrow Signed-off-by: Pranav C --- packages/nc-gui/components.d.ts | 1 + packages/nc-gui/components/smartsheet/expanded-form/Header.vue | 2 ++ 2 files changed, 3 insertions(+) diff --git a/packages/nc-gui/components.d.ts b/packages/nc-gui/components.d.ts index 99bc5645f2..c790b16d76 100644 --- a/packages/nc-gui/components.d.ts +++ b/packages/nc-gui/components.d.ts @@ -204,6 +204,7 @@ declare module '@vue/runtime-core' { MdiLogout: typeof import('~icons/mdi/logout')['default'] MdiMagnify: typeof import('~icons/mdi/magnify')['default'] MdiMenu: typeof import('~icons/mdi/menu')['default'] + MdiMenuArrowDown: typeof import('~icons/mdi/menu-arrow-down')['default'] MdiMenuDown: typeof import('~icons/mdi/menu-down')['default'] MdiMicrosoftTeams: typeof import('~icons/mdi/microsoft-teams')['default'] MdiMinusCircleOutline: typeof import('~icons/mdi/minus-circle-outline')['default'] diff --git a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue index c22057348a..3f235af669 100644 --- a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue +++ b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue @@ -185,6 +185,8 @@ const onConfirmDeleteRowClick = async () => { + + @@ -206,3 +206,9 @@ const onConfirmDeleteRowClick = async () => { + + From 952413f54531014a42e4db608dca4c51bd4f2cc3 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Thu, 16 Feb 2023 16:23:57 +0530 Subject: [PATCH 7/8] chore: lint Signed-off-by: Pranav C --- .../nc-gui/components/smartsheet/expanded-form/Header.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue index f9030ae66d..8e0a5d6faa 100644 --- a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue +++ b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue @@ -108,7 +108,11 @@ const onConfirmDeleteRowClick = async () => { - + diff --git a/tests/playwright/pages/Dashboard/ExpandedForm/index.ts b/tests/playwright/pages/Dashboard/ExpandedForm/index.ts index 538c2e4ff7..fa66bebd0c 100644 --- a/tests/playwright/pages/Dashboard/ExpandedForm/index.ts +++ b/tests/playwright/pages/Dashboard/ExpandedForm/index.ts @@ -133,7 +133,7 @@ export class ExpandedFormPage extends BasePage { } async close() { - await this.get().locator('button:has-text("Close")').last().click(); + await this.get().locator('.nc-close-form').last().click(); } async openChildCard(param: { column: string; title: string }) {