From 40f02d5be786edced5d7b385b4fc8b9a86f44fc0 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 17 May 2024 09:35:48 +0000
Subject: [PATCH] test: erd test correction

---
 .../components/dashboard/settings/DataSources.vue      |  2 +-
 .../playwright/pages/Dashboard/Settings/DataSources.ts | 10 +++++++---
 tests/playwright/tests/db/features/erd.spec.ts         |  6 ++++--
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/settings/DataSources.vue b/packages/nc-gui/components/dashboard/settings/DataSources.vue
index be017b44ec..d580910f8b 100644
--- a/packages/nc-gui/components/dashboard/settings/DataSources.vue
+++ b/packages/nc-gui/components/dashboard/settings/DataSources.vue
@@ -323,7 +323,7 @@ const openedTab = ref('erd')
         </a-breadcrumb-item>
       </a-breadcrumb>
     </div>
-    <div class="flex flex-row w-full h-full nc-data-sources-view flex-grow">
+    <div data-testid="nc-settings-datasources" class="flex flex-row w-full h-full nc-data-sources-view flex-grow">
       <template v-if="activeSource">
         <NcTabs v-model:activeKey="openedTab" class="nc-source-tab w-full">
           <a-tab-pane key="erd">
diff --git a/tests/playwright/pages/Dashboard/Settings/DataSources.ts b/tests/playwright/pages/Dashboard/Settings/DataSources.ts
index d1b5ce646e..301a24d6a0 100644
--- a/tests/playwright/pages/Dashboard/Settings/DataSources.ts
+++ b/tests/playwright/pages/Dashboard/Settings/DataSources.ts
@@ -20,11 +20,15 @@ export class DataSourcesPage extends BasePage {
   }
 
   get() {
-    return this.settings.get().locator(`[data-testid="nc-settings-subtab-Data Sources"]`);
+    return this.settings.get().locator('[data-testid="nc-settings-datasources"]');
   }
 
-  async openErd({ dataSourceName }: { dataSourceName: string }) {
-    await this.get().locator('.ds-table-row', { hasText: dataSourceName }).locator('button:has-text("ERD")').click();
+  async openErd({ rowIndex }: { rowIndex: number }) {
+    const row = this.get()
+      .locator('.ds-table-row')
+      .nth(rowIndex + 1);
+    await row.click();
+    await this.get().getByTestId('nc-erd-tab').click();
   }
 
   async openAcl({ dataSourceName = defaultBaseName }: { dataSourceName?: string } = {}) {
diff --git a/tests/playwright/tests/db/features/erd.spec.ts b/tests/playwright/tests/db/features/erd.spec.ts
index 3dca369431..345696bac0 100644
--- a/tests/playwright/tests/db/features/erd.spec.ts
+++ b/tests/playwright/tests/db/features/erd.spec.ts
@@ -45,8 +45,10 @@ test.describe('Erd', () => {
   };
 
   const openProjectErd = async () => {
-    await dashboard.baseView.tab_dataSources.click();
-    await dashboard.baseView.dataSources.openERD({ rowIndex: 0 });
+    await dashboard.treeView.baseSettings({ title: context.base.title });
+    await dashboard.settings.selectTab({ tab: 'dataSources' });
+    await dashboard.settings.dataSources.openErd({ rowIndex: 0 });
+    // await dashboard.baseView.dataSources.openERD({ rowIndex: 0 });
   };
 
   const openErdOfATable = async (tableName: string) => {