From edad796ab4ef4c001a16118d49b81ee7e8e7ade1 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 19 Jul 2022 00:42:27 +0530 Subject: [PATCH 01/46] feat: move project create pages to subpages Signed-off-by: Pranav C --- packages/nc-gui-v2/components.d.ts | 3 + packages/nc-gui-v2/pages/index/index.vue | 4 +- .../nc-gui-v2/pages/index/index/index.vue | 7 +- packages/nc-gui-v2/pages/index/index/list.vue | 2 +- packages/nc-gui-v2/pages/projects/index.vue | 155 +----------------- .../projects/{ => index}/create-external.vue | 0 .../pages/projects/{ => index}/create.vue | 60 +++++-- 7 files changed, 62 insertions(+), 169 deletions(-) rename packages/nc-gui-v2/pages/projects/{ => index}/create-external.vue (100%) rename packages/nc-gui-v2/pages/projects/{ => index}/create.vue (58%) diff --git a/packages/nc-gui-v2/components.d.ts b/packages/nc-gui-v2/components.d.ts index 49767446cb..47dd2cd544 100644 --- a/packages/nc-gui-v2/components.d.ts +++ b/packages/nc-gui-v2/components.d.ts @@ -7,6 +7,9 @@ export {} declare module '@vue/runtime-core' { export interface GlobalComponents { + AButton: typeof import('ant-design-vue/es')['Button'] + ACard: typeof import('ant-design-vue/es')['Card'] + ACheckbox: typeof import('ant-design-vue/es')['Checkbox'] ADivider: typeof import('ant-design-vue/es')['Divider'] ADropdown: typeof import('ant-design-vue/es')['Dropdown'] AForm: typeof import('ant-design-vue/es')['Form'] diff --git a/packages/nc-gui-v2/pages/index/index.vue b/packages/nc-gui-v2/pages/index/index.vue index efda169de5..a0812c0ace 100644 --- a/packages/nc-gui-v2/pages/index/index.vue +++ b/packages/nc-gui-v2/pages/index/index.vue @@ -81,14 +81,14 @@ const visible = ref(true)
{{ $t('activity.createProject') }}
diff --git a/packages/nc-gui-v2/pages/index/index/index.vue b/packages/nc-gui-v2/pages/index/index/index.vue index 7f09818aef..461e825a2f 100644 --- a/packages/nc-gui-v2/pages/index/index/index.vue +++ b/packages/nc-gui-v2/pages/index/index/index.vue @@ -50,13 +50,16 @@ const formatTitle = (title: string) =>
-
+
{{ $t('activity.createProject') }}
diff --git a/packages/nc-gui-v2/pages/index/index/list.vue b/packages/nc-gui-v2/pages/index/index/list.vue index d69159b566..4d2fe80da0 100644 --- a/packages/nc-gui-v2/pages/index/index/list.vue +++ b/packages/nc-gui-v2/pages/index/index/list.vue @@ -13,7 +13,7 @@ const { projects = [] } = defineProps() const emit = defineEmits(['delete-project']) -const { $e } = useNuxtApp() +const { $e } = useNxuxtApp() const openProject = async (project: ProjectType) => { await navigateTo(`/nc/${project.id}`) diff --git a/packages/nc-gui-v2/pages/projects/index.vue b/packages/nc-gui-v2/pages/projects/index.vue index e26a1ef829..ea14b8a330 100644 --- a/packages/nc-gui-v2/pages/projects/index.vue +++ b/packages/nc-gui-v2/pages/projects/index.vue @@ -1,150 +1,13 @@ - - + + diff --git a/packages/nc-gui-v2/pages/projects/create-external.vue b/packages/nc-gui-v2/pages/projects/index/create-external.vue similarity index 100% rename from packages/nc-gui-v2/pages/projects/create-external.vue rename to packages/nc-gui-v2/pages/projects/index/create-external.vue diff --git a/packages/nc-gui-v2/pages/projects/create.vue b/packages/nc-gui-v2/pages/projects/index/create.vue similarity index 58% rename from packages/nc-gui-v2/pages/projects/create.vue rename to packages/nc-gui-v2/pages/projects/index/create.vue index f552bf1b62..c96f548e7f 100644 --- a/packages/nc-gui-v2/pages/projects/create.vue +++ b/packages/nc-gui-v2/pages/projects/index/create.vue @@ -28,11 +28,50 @@ const createProject = async () => { } loading.value = false } + +const formState = reactive({ + username: '', + password: '', + remember: true, +}) +const onFinish = (values: any) => { + console.log('Success:', values) +} + +const onFinishFailed = (errorInfo: any) => { + console.log('Failed:', errorInfo) +} - - From 5552b564b4bb2a1576bee53e074032d9afa70275 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 19 Jul 2022 12:43:18 +0530 Subject: [PATCH 02/46] feat(gui-v2): add crete project form validation Signed-off-by: Pranav C --- .../nc-gui-v2/pages/projects/index/create.vue | 84 ++++++------------- 1 file changed, 25 insertions(+), 59 deletions(-) diff --git a/packages/nc-gui-v2/pages/projects/index/create.vue b/packages/nc-gui-v2/pages/projects/index/create.vue index c96f548e7f..a9ef83c2a0 100644 --- a/packages/nc-gui-v2/pages/projects/index/create.vue +++ b/packages/nc-gui-v2/pages/projects/index/create.vue @@ -11,15 +11,29 @@ const valid = ref(false) const { $api, $toast } = useNuxtApp() const nameValidationRules = [ - (v: string) => !!v || 'Title is required', - (v: string) => v.length <= 50 || 'Project name exceeds 50 characters', + { + required: true, + message: 'Title is required', + }, + { + validator(rule: any, value: any, callback: (errMsg?: string) => void) { + if (value?.length > 50) { + callback('Project name exceeds 50 characters') + } + callback() + }, + }, ] +const formState = reactive({ + title: '', +}) + const createProject = async () => { loading.value = true try { const result = await $api.project.create({ - title: name.value, + title: formState.title, }) await navigateTo(`/nc/${result.id}`) @@ -28,71 +42,23 @@ const createProject = async () => { } loading.value = false } - -const formState = reactive({ - username: '', - password: '', - remember: true, -}) -const onFinish = (values: any) => { - console.log('Success:', values) -} - -const onFinishFailed = (errorInfo: any) => { - console.log('Failed:', errorInfo) -} From a362a14d568a5eb1691c9f22d905fb4e83a7cd7e Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 19 Jul 2022 12:48:08 +0530 Subject: [PATCH 03/46] feat(gui-v2): project create api invoke Signed-off-by: Pranav C --- packages/nc-gui-v2/pages/projects/index/create.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nc-gui-v2/pages/projects/index/create.vue b/packages/nc-gui-v2/pages/projects/index/create.vue index a9ef83c2a0..1cf5e7dba1 100644 --- a/packages/nc-gui-v2/pages/projects/index/create.vue +++ b/packages/nc-gui-v2/pages/projects/index/create.vue @@ -48,7 +48,7 @@ const createProject = async () => {

{{ $t('activity.createProject') }}

- + From 2fca8f921037381634a0f782bfc8aebc5f10cc94 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 19 Jul 2022 13:21:30 +0530 Subject: [PATCH 04/46] refactor(gui-v2): add box shadow Signed-off-by: Pranav C --- packages/nc-gui-v2/components.d.ts | 5 +++++ packages/nc-gui-v2/pages/projects/index/create.vue | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui-v2/components.d.ts b/packages/nc-gui-v2/components.d.ts index 47dd2cd544..49b2967468 100644 --- a/packages/nc-gui-v2/components.d.ts +++ b/packages/nc-gui-v2/components.d.ts @@ -10,11 +10,13 @@ declare module '@vue/runtime-core' { AButton: typeof import('ant-design-vue/es')['Button'] ACard: typeof import('ant-design-vue/es')['Card'] ACheckbox: typeof import('ant-design-vue/es')['Checkbox'] + ACol: typeof import('ant-design-vue/es')['Col'] ADivider: typeof import('ant-design-vue/es')['Divider'] ADropdown: typeof import('ant-design-vue/es')['Dropdown'] AForm: typeof import('ant-design-vue/es')['Form'] AFormItem: typeof import('ant-design-vue/es')['FormItem'] AInput: typeof import('ant-design-vue/es')['Input'] + AInputNumber: typeof import('ant-design-vue/es')['InputNumber'] AInputPassword: typeof import('ant-design-vue/es')['InputPassword'] ALayout: typeof import('ant-design-vue/es')['Layout'] ALayoutContent: typeof import('ant-design-vue/es')['LayoutContent'] @@ -24,6 +26,9 @@ declare module '@vue/runtime-core' { AMenuDivider: typeof import('ant-design-vue/es')['MenuDivider'] AMenuItem: typeof import('ant-design-vue/es')['MenuItem'] AModal: typeof import('ant-design-vue/es')['Modal'] + ARow: typeof import('ant-design-vue/es')['Row'] + ASelect: typeof import('ant-design-vue/es')['Select'] + ASelectOption: typeof import('ant-design-vue/es')['SelectOption'] ASubMenu: typeof import('ant-design-vue/es')['SubMenu'] ATable: typeof import('ant-design-vue/es')['Table'] RouterLink: typeof import('vue-router')['RouterLink'] diff --git a/packages/nc-gui-v2/pages/projects/index/create.vue b/packages/nc-gui-v2/pages/projects/index/create.vue index 1cf5e7dba1..924f37a41f 100644 --- a/packages/nc-gui-v2/pages/projects/index/create.vue +++ b/packages/nc-gui-v2/pages/projects/index/create.vue @@ -45,11 +45,11 @@ const createProject = async () => {