From 40664e1e4abc59f2159b102b08ca93d2b8d27595 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Sat, 12 Oct 2024 01:54:11 +0530
Subject: [PATCH] chore: optimize docker build time

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .github/workflows/release-timely-docker.yml |  4 +-
 packages/nocodb/Dockerfile.timely           | 56 +++++++++++++--------
 packages/nocodb/package.json                |  2 +-
 3 files changed, 37 insertions(+), 25 deletions(-)

diff --git a/.github/workflows/release-timely-docker.yml b/.github/workflows/release-timely-docker.yml
index 1841d8562f..7ca567f31a 100644
--- a/.github/workflows/release-timely-docker.yml
+++ b/.github/workflows/release-timely-docker.yml
@@ -78,7 +78,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
         with:
-          fetch-depth: 0
+          fetch-depth: 1
           ref: ${{ github.ref }}
 
       - name: Use Node.js ${{ matrix.node-version }}
@@ -144,7 +144,7 @@ jobs:
           context: ${{ env.working-directory }}
           file: ${{ env.working-directory }}/Dockerfile.timely
           build-args: NC_VERSION=${{ steps.get-docker-repository.outputs.DOCKER_BUILD_TAG }}
-          platforms: linux/amd64,linux/arm64,linux/arm/v7
+          platforms: linux/amd64,linux/arm64
           cache-from: type=local,src=/tmp/.buildx-cache
           cache-to: type=local,dest=/tmp/.buildx-cache-new
           push: true
diff --git a/packages/nocodb/Dockerfile.timely b/packages/nocodb/Dockerfile.timely
index 0cdb946ccf..441c7bc322 100644
--- a/packages/nocodb/Dockerfile.timely
+++ b/packages/nocodb/Dockerfile.timely
@@ -1,29 +1,31 @@
-# syntax=docker/dockerfile:1
+# syntax=docker/dockerfile:1.5
+# Use Buildx cross-compilation
 
 ###########
 # Litestream Builder
 ###########
-FROM golang:alpine3.19 as lt-builder
+FROM --platform=$BUILDPLATFORM golang:alpine3.19 as lt-builder
 
 WORKDIR /usr/src/
 
-RUN apk add --no-cache git make musl-dev gcc
+# Use build platform-specific tools
+RUN apk --no-cache add git make musl-dev gcc
 
-# build litestream
-RUN git clone https://github.com/benbjohnson/litestream.git litestream
-RUN cd litestream && go install ./cmd/litestream
-RUN cp $GOPATH/bin/litestream /usr/src/lt
+# Build litestream for target platform
+RUN git clone https://github.com/benbjohnson/litestream.git litestream \
+    && cd litestream && GOARCH=$(go env GOARCH) GOOS=$(go env GOOS) go install ./cmd/litestream \
+    && cp $GOPATH/bin/litestream /usr/src/lt
 
 ###########
 # Builder
 ###########
-FROM node:18.19.1-alpine as builder
+FROM --platform=$BUILDPLATFORM node:18.19.1-alpine as builder
 WORKDIR /usr/src/app
 
-# install node-gyp dependencies
+# Install node-gyp dependencies
 RUN apk add --no-cache python3 make g++
 
-# install pnpm
+# Install pnpm
 RUN corepack enable && corepack prepare pnpm@latest --activate
 
 # Copy application dependency manifests to the container image.
@@ -33,22 +35,33 @@ COPY --link ./docker/start-litestream.sh /usr/src/appEntry/start.sh
 COPY --link src/public/ ./docker/public/
 COPY --link ./docker/nc-gui/ ./docker/nc-gui/
 
-# for pnpm to generate a flat node_modules without symlinks
-# so that modclean could work as expected
+# For pnpm to generate a flat node_modules without symlinks
+# So that modclean works as expected
 RUN echo "node-linker=hoisted" > .npmrc
 
-# install production dependencies,
-# reduce node_module size with modclean & removing sqlite deps,
-# and add execute permission to start.sh
+# Install production dependencies, reduce node_module size with modclean
+# Removing sqlite deps and add execute permission to start.sh
 RUN pnpm install --prod --shamefully-hoist \
     && pnpm dlx modclean --patterns="default:*" --ignore="nc-lib-gui/**,dayjs/**,express-status-monitor/**,@azure/msal-node/dist/**" --run  \
     && rm -rf ./node_modules/sqlite3/deps \
     && chmod +x /usr/src/appEntry/start.sh
+#    && (pnpm exec prebuild-install -- --platform=$TARGETPLATFORM --arch=$TARGETARCH -r napi || echo "Prebuilt binary not available") \
+#    && npm install sqlite3 --target_arch=$BUILDARCH --target_platform=$BUILDOS --legacy-peer-deps \
 
-##########
+
+############
+## Sqlite3 Builder
+############
+FROM node:18.19.1-alpine as sqlite-builder
+WORKDIR /usr/src/app
+
+# Install sqlite3 for the target platform to copy to the final image
+RUN npm init -y && npm install sqlite3
+
+###########
 # Runner
-##########
-FROM alpine:3.19
+###########
+FROM --platform=$TARGETPLATFORM alpine:3.19
 WORKDIR /usr/src/app
 
 ENV LITESTREAM_S3_SKIP_VERIFY=false \
@@ -61,16 +74,15 @@ ENV LITESTREAM_S3_SKIP_VERIFY=false \
     NODE_ENV=production \
     PORT=8080
 
-RUN apk add --update --no-cache \
-    dasel \
-    dumb-init \
-    nodejs
+RUN apk add --update --no-cache dasel dumb-init nodejs
 
 # Copy litestream binary and config file
 COPY --link --from=lt-builder /usr/src/lt /usr/local/bin/litestream
 COPY --link ./docker/litestream.yml /etc/litestream.yml
+
 # Copy production code & main entry file
 COPY --link --from=builder /usr/src/app/ /usr/src/app/
+COPY --link --from=sqlite-builder /usr/src/app/node_modules/sqlite3/ /usr/src/app/node_modules/sqlite3/
 COPY --link --from=builder /usr/src/appEntry/ /usr/src/appEntry/
 
 EXPOSE 8080
diff --git a/packages/nocodb/package.json b/packages/nocodb/package.json
index e9a464a287..a60ddf4497 100644
--- a/packages/nocodb/package.json
+++ b/packages/nocodb/package.json
@@ -197,4 +197,4 @@
     "typescript": "^5.3.3",
     "webpack-cli": "^5.1.4"
   }
-}
\ No newline at end of file
+}