From 401c8408701df352c79a7af2cce7bfd452f3abef Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Thu, 23 Nov 2023 07:02:56 +0000
Subject: [PATCH] fix: Disabled view rename if view is locked

---
 .../smartsheet/toolbar/ViewActionMenu.vue       | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
index 087205e9dc..7616aaf08e 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
@@ -26,7 +26,7 @@ const view = computed(() => props.view)
 
 const table = computed(() => props.table)
 
-const { viewsByTable, isActiveViewLocked: isLocked } = storeToRefs(useViewsStore())
+const { viewsByTable } = storeToRefs(useViewsStore())
 const { loadViews, navigateToView } = useViewsStore()
 
 const { base } = storeToRefs(useBase())
@@ -56,7 +56,7 @@ const quickImportDialogs: Record<(typeof quickImportDialogTypes)[number], Ref<bo
 ) as Record<QuickImportDialogType, Ref<boolean>>
 
 const onImportClick = (dialog: any) => {
-  if (isLocked.value) return
+  if (lockType.value === LockType.Locked) return
 
   emits('closeModal')
   dialog.value = true
@@ -161,10 +161,17 @@ const onDelete = async () => {
     </NcTooltip>
     <NcDivider />
     <template v-if="!view?.is_default">
-      <NcMenuItem @click="onRenameMenuClick">
+      <NcMenuItem v-if="lockType !== LockType.Locked" @click="onRenameMenuClick">
         <GeneralIcon icon="edit" />
         {{ $t('activity.renameView') }}
       </NcMenuItem>
+      <NcTooltip v-else>
+        <template #title> {{ $t('msg.info.disabledAsViewLocked') }} </template>
+        <NcMenuItem class="!cursor-not-allowed !text-gray-400">
+          <GeneralIcon icon="edit" />
+          {{ $t('activity.renameView') }}
+        </NcMenuItem>
+      </NcTooltip>
       <NcMenuItem @click="onDuplicate">
         <GeneralIcon icon="duplicate" class="nc-view-copy-icon" />
         {{ $t('labels.duplicateView') }}
@@ -203,7 +210,7 @@ const onDelete = async () => {
                   },
                 ]"
                 class="nc-base-menu-item"
-                :class="{ disabled: isLocked }"
+                :class="{ disabled: lockType === LockType.Locked }"
               >
                 <component :is="iconMap.upload" />
                 {{ `${$t('general.upload')} ${type.toUpperCase()}` }}
@@ -272,7 +279,7 @@ const onDelete = async () => {
     </NcSubMenu>
     <template v-if="!view.is_default">
       <NcDivider />
-      <NcTooltip v-if="isLocked">
+      <NcTooltip v-if="lockType === LockType.Locked">
         <template #title> {{ $t('msg.info.disabledAsViewLocked') }} </template>
         <NcMenuItem class="!cursor-not-allowed !text-gray-400">
           <GeneralIcon icon="delete" class="nc-view-delete-icon" />