From 3f2d95e08ba015fc79823850570b921a2d2fcea1 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Sat, 17 Feb 2024 06:09:50 +0000
Subject: [PATCH] fix(nc-gui): pr review changes #2326

---
 packages/nc-gui/components/account/UserList.vue    |  2 +-
 .../components/smartsheet/details/Webhooks.vue     |  7 ++-----
 .../virtual-cell/components/ListChildItems.vue     | 13 ++++---------
 .../components/workspace/CollaboratorsList.vue     |  2 +-
 packages/nc-gui/lang/en.json                       | 14 ++++++--------
 5 files changed, 14 insertions(+), 24 deletions(-)

diff --git a/packages/nc-gui/components/account/UserList.vue b/packages/nc-gui/components/account/UserList.vue
index 8c24bf0048..410e23e820 100644
--- a/packages/nc-gui/components/account/UserList.vue
+++ b/packages/nc-gui/components/account/UserList.vue
@@ -347,7 +347,7 @@ const openDeleteModal = (user: UserType) => {
           </div>
           <div
             v-if="sortedUsers.length === 1"
-            class="user pt-12 pb-4 flex flex-col items-center gap-6 text-center border-b-1 border-l-1 border-r-1"
+            class="user pt-12 pb-4 px-2 flex flex-col items-center gap-6 text-center border-b-1 border-l-1 border-r-1"
           >
             <div class="text-2xl text-gray-800 font-bold">
               {{ $t('placeholder.inviteYourTeam') }}
diff --git a/packages/nc-gui/components/smartsheet/details/Webhooks.vue b/packages/nc-gui/components/smartsheet/details/Webhooks.vue
index 8260c82d23..0dc8046762 100644
--- a/packages/nc-gui/components/smartsheet/details/Webhooks.vue
+++ b/packages/nc-gui/components/smartsheet/details/Webhooks.vue
@@ -199,11 +199,8 @@ watch(
     <div v-if="!selectedHookId && !isDraftMode" class="flex flex-col h-full w-full items-center">
       <div v-if="hooks.length === 0" class="flex flex-col px-1.5 py-2.5 ml-1 h-full items-center gap-y-6 text-center">
         <img src="~assets/img/placeholder/webhooks.png" class="!w-[24rem] flex-none" />
-        <div class="flex text-gray-700 font-bold text-2xl">{{ $t('msg.createWebhookMsg1') }}</div>
-        <div class="flex flex-col items-center ext-gray-700">
-          <div class="flex">{{ $t('msg.createWebhookMsg2') }}</div>
-          <div class="flex">{{ $t('msg.createWebhookMsg3') }}</div>
-        </div>
+        <div class="text-gray-700 font-bold text-2xl">{{ $t('msg.createWebhookMsg1') }}</div>
+        <div class="text-gray-700 max-w-[24rem]">{{ $t('msg.createWebhookMsg2') }}</div>
         <NcButton v-e="['c:actions:webhook']" class="flex max-w-40" type="primary" @click="createWebhook()">
           <div class="flex flex-row items-center justify-between w-full">
             <span class="ml-1">{{ $t('activity.newWebhook') }}</span>
diff --git a/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue b/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
index 65b1771ab4..fed18d1b11 100644
--- a/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
@@ -299,16 +299,11 @@ onUnmounted(() => {
           </template>
         </div>
       </div>
-      <div v-else class="pt-1 flex flex-col gap-4 my-auto items-center justify-center text-gray-500">
+      <div v-else class="pt-1 flex flex-col gap-4 my-auto items-center justify-center text-gray-500 text-center">
         <img src="~assets/img/placeholder/link-records.png" class="!w-[18.5rem] flex-none" />
-        <div class="text-2xl text-gray-700 font-bold text-center">{{ $t('msg.noLinkedRecords') }}</div>
-        <div class="text-center text-gray-700">
-          <div>
-            {{ $t('msg.noRecordsHaveBeenLinkedYetFromTable', { tableName: relatedTableMeta?.title }) }}
-          </div>
-          <div>
-            {{ $t('msg.clickLinkRecordsToAddLink') }}
-          </div>
+        <div class="text-2xl text-gray-700 font-bold">{{ $t('msg.noLinkedRecords') }}</div>
+        <div class="text-gray-700">
+          {{ $t('msg.clickLinkRecordsToAddLinkFromTable', { tableName: relatedTableMeta?.title }) }}
         </div>
 
         <NcButton
diff --git a/packages/nc-gui/components/workspace/CollaboratorsList.vue b/packages/nc-gui/components/workspace/CollaboratorsList.vue
index ded6041bba..f40602c2d2 100644
--- a/packages/nc-gui/components/workspace/CollaboratorsList.vue
+++ b/packages/nc-gui/components/workspace/CollaboratorsList.vue
@@ -152,7 +152,7 @@ onMounted(async () => {
               </NcDropdown>
             </div>
           </div>
-          <div v-if="sortedCollaborators.length === 1" class="pt-12 pb-4 flex flex-col items-center gap-6 text-center">
+          <div v-if="sortedCollaborators.length === 1" class="pt-12 pb-4 px-2 flex flex-col items-center gap-6 text-center">
             <div class="text-2xl text-gray-800 font-bold">
               {{ $t('placeholder.inviteYourTeam') }}
             </div>
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 5c11a45edf..20e0907155 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -667,7 +667,7 @@
       "deletedField": "Deleted field",
       "incompleteConfiguration": "Incomplete configuration",
       "selectField": "Select a field",
-      "selectFieldLabel": "Make changes to field properties by selecting a field from the list"
+      "selectFieldLabel": "Begin by selecting a field to customise its properties and structure."
     }
   },
   "activity": {
@@ -963,11 +963,11 @@
     "value": "Value",
     "key": "Key",
     "createTable": "Create your First Table!",
-    "createTableLabel": "From scratch or import or connect to external database",
+    "createTableLabel": "Create your first table effortlessly, from scratch, or by importing/connecting to an external database.",
     "noTokenCreated":"No API Tokens created",
-    "noTokenCreatedLabel" :"Looks like you haven’t generated any API tokens yet.",
+    "noTokenCreatedLabel" :"Begin by creating API tokens to unlock advanced functionalities.",
     "inviteYourTeam": "Invite your team",
-    "inviteYourTeamLabel": "Fast track your projects by collaborating on them with your team!"
+    "inviteYourTeamLabel": "Streamline collaboration and productivity with your team – start by inviting them to join your workspace."
   },
   "msg": {
     "clickToCopyFieldId": "Click to copy Field Id",
@@ -1052,8 +1052,7 @@
       "tooltip_desc": "A single record from table ",
       "tooltip_desc2": " can be linked with a single record from table "
     },
-    "noRecordsHaveBeenLinkedYetFromTable": "Looks like no records have been linked yet from table {tableName}.",
-    "clickLinkRecordsToAddLink": "Click on Link records to do so.",
+    "clickLinkRecordsToAddLinkFromTable": "Click 'Link Records' to begin associating data with '{tableName}'.",
     "noRecordsLinked": "No records linked",
     "noLinkedRecords": "No linked records",
     "recordsLinked": "records linked",
@@ -1063,8 +1062,7 @@
     "selectFieldToGroup": "Select Field to Group",
     "thereAreNoRecordsInTable": "There are no records in table",
     "createWebhookMsg1": "Get started with web-hooks!",
-    "createWebhookMsg2": "Create web-hooks to power you automations,",
-    "createWebhookMsg3": "Get notified as soon as there are changes in your data",
+    "createWebhookMsg2": "Power you automations. Get notified as soon as there are changes in your data",
     "areYouSureUWantTo": "Are you sure you want to delete the following",
     "areYouSureUWantToDeleteLabel": "Are you sure you want to {deleteLabel} the following",
     "idColumnRequired": "ID field is required, you can rename this later if required.",