From cc564fa211e67b891daa80c5633503cc8bd9570f Mon Sep 17 00:00:00 2001
From: Roni Bytyqi <roni@spaxel.com>
Date: Tue, 19 Nov 2024 08:53:42 +0100
Subject: [PATCH] fix(GCS): set the response headers accordingly

use the appropriate properties for setting the response headers in
options object when requesting the signed url (based on the
GetSignedUrlConfig interface).

Reference:
https://cloud.google.com/nodejs/docs/reference/storage/latest/storage/getsignedurlconfig

related to #9350
---
 packages/nocodb/src/plugins/gcs/Gcs.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/nocodb/src/plugins/gcs/Gcs.ts b/packages/nocodb/src/plugins/gcs/Gcs.ts
index 3ffe32bbc3..c0701d49a3 100644
--- a/packages/nocodb/src/plugins/gcs/Gcs.ts
+++ b/packages/nocodb/src/plugins/gcs/Gcs.ts
@@ -179,7 +179,8 @@ export default class Gcs implements IStorageAdapterV2 {
       version: 'v4',
       action: 'read',
       expires: Date.now() + expiresInSeconds * 1000,
-      extensionHeaders: pathParameters,
+      responseDisposition: pathParameters?.ResponseContentDisposition,
+      responseType: pathParameters?.ResponseContentType
     };
 
     const [url] = await this.storageClient