From 3cc5dfcd48d52b8d1d14e767a32678054dbe91bc Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Sat, 17 Sep 2022 14:06:32 +0800 Subject: [PATCH] refactor(nc-gui): remove unncessary watch & add ref to inject --- packages/nc-gui/components/smartsheet/Kanban.vue | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/packages/nc-gui/components/smartsheet/Kanban.vue b/packages/nc-gui/components/smartsheet/Kanban.vue index 86e0f4f978..afc899b05e 100644 --- a/packages/nc-gui/components/smartsheet/Kanban.vue +++ b/packages/nc-gui/components/smartsheet/Kanban.vue @@ -18,9 +18,9 @@ import { import Row from '~/components/smartsheet/Row.vue' import type { Row as RowType } from '~/composables' -const meta = inject(MetaInj) +const meta = inject(MetaInj, ref()) -const view = inject(ActiveViewInj) +const view = inject(ActiveViewInj, ref()) const reloadViewDataHook = inject(ReloadViewDataHookInj) @@ -64,17 +64,6 @@ provide(ReadonlyInj, !isUIAllowed('xcDatatableEditable')) const fields = inject(FieldsInj, ref([])) -watch( - [meta, view], - async () => { - if (meta?.value && view?.value) { - await loadKanbanMeta() - await loadKanbanData() - } - }, - { immediate: true }, -) - const isRowEmpty = (record: any, col: any) => { const val = record.row[col.title] if (!val) return true