From 3c2720d449700f55fc7ea5a08b05996e56863b4d Mon Sep 17 00:00:00 2001 From: Muhammed Mustafa Date: Thu, 3 Nov 2022 16:03:59 +0530 Subject: [PATCH] feat(testing): Integrated data-nc standard for dom attribute used for testing --- .../nc-gui/components/cell/MultiSelect.vue | 2 +- .../nc-gui/components/cell/SingleSelect.vue | 2 +- .../components/cell/attachment/index.vue | 2 +- .../nc-gui/components/dashboard/TreeView.vue | 8 +-- .../dashboard/settings/AuditTab.vue | 2 +- .../components/dashboard/settings/Modal.vue | 4 +- .../nc-gui/components/dlg/TableCreate.vue | 2 +- .../components/general/TruncateText.vue | 2 +- .../nc-gui/components/smartsheet/Form.vue | 46 ++++++------- .../nc-gui/components/smartsheet/Gallery.vue | 4 +- .../nc-gui/components/smartsheet/Grid.vue | 22 +++---- .../nc-gui/components/smartsheet/Kanban.vue | 2 +- .../components/smartsheet/Pagination.vue | 2 +- .../smartsheet/column/EditOrAdd.vue | 2 +- .../smartsheet/column/SelectOptions.vue | 6 +- .../smartsheet/expanded-form/index.vue | 2 +- .../smartsheet/sidebar/RenameableMenuItem.vue | 8 +-- .../smartsheet/toolbar/ColumnFilterMenu.vue | 2 +- .../smartsheet/toolbar/FieldsMenu.vue | 4 +- .../smartsheet/toolbar/ShareView.vue | 16 ++--- .../smartsheet/toolbar/SortListMenu.vue | 2 +- .../smartsheet/toolbar/ViewActions.vue | 2 +- .../tabs/auth/user-management/ShareBase.vue | 2 +- packages/nc-gui/layouts/base.vue | 2 +- packages/nc-gui/layouts/shared-view.vue | 2 +- .../pages/[projectType]/[projectId]/index.vue | 2 +- .../[projectType]/[projectId]/index/index.vue | 6 +- .../form/[viewId]/index/index.vue | 6 +- .../form/[viewId]/index/survey.vue | 26 ++++---- packages/nc-gui/pages/index/index/index.vue | 6 +- packages/nc-gui/pages/signin.vue | 6 +- .../pages/Dashboard/ExpandedForm/index.ts | 6 +- .../playwright/pages/Dashboard/Form/index.ts | 64 +++++++++---------- .../pages/Dashboard/Gallery/index.ts | 2 +- .../Grid/Column/SelectOptionColumn.ts | 14 ++-- .../pages/Dashboard/Grid/Column/index.ts | 2 +- .../playwright/pages/Dashboard/Grid/index.ts | 34 +++++----- .../pages/Dashboard/Kanban/index.ts | 4 +- .../pages/Dashboard/Settings/Acl.ts | 2 +- .../pages/Dashboard/Settings/AppStore.ts | 2 +- .../pages/Dashboard/Settings/Audit.ts | 2 +- .../pages/Dashboard/Settings/Erd.ts | 2 +- .../pages/Dashboard/Settings/Metadata.ts | 2 +- .../pages/Dashboard/Settings/Miscellaneous.ts | 2 +- .../pages/Dashboard/Settings/Teams.ts | 4 +- .../pages/Dashboard/Settings/index.ts | 2 +- .../pages/Dashboard/SurveyForm/index.ts | 26 ++++---- .../playwright/pages/Dashboard/TreeView.ts | 4 +- .../pages/Dashboard/ViewSidebar/index.ts | 20 +++--- .../Dashboard/common/Cell/AttachmentCell.ts | 4 +- .../Dashboard/common/Cell/SelectOptionCell.ts | 4 +- .../pages/Dashboard/common/Cell/index.ts | 4 +- .../Dashboard/common/ProjectMenu/index.ts | 4 +- .../Dashboard/common/Toolbar/Actions/index.ts | 2 +- .../pages/Dashboard/common/Toolbar/Fields.ts | 8 +-- .../pages/Dashboard/common/Toolbar/Filter.ts | 4 +- .../Dashboard/common/Toolbar/ShareView.ts | 14 ++-- .../pages/Dashboard/common/Toolbar/Sort.ts | 4 +- scripts/playwright/pages/Dashboard/index.ts | 16 ++--- scripts/playwright/pages/LoginPage/index.ts | 8 +-- .../playwright/pages/ProjectsPage/index.ts | 6 +- scripts/playwright/pages/SharedForm/index.ts | 2 +- 62 files changed, 235 insertions(+), 241 deletions(-) diff --git a/packages/nc-gui/components/cell/MultiSelect.vue b/packages/nc-gui/components/cell/MultiSelect.vue index dd59a31f94..2bffd5ff04 100644 --- a/packages/nc-gui/components/cell/MultiSelect.vue +++ b/packages/nc-gui/components/cell/MultiSelect.vue @@ -155,7 +155,7 @@ watch(isOpen, (n, _o) => { v-for="op of options" :key="op.id" :value="op.title" - :pw-data="`select-option-${column.title}-${rowIndex}`" + :data-nc="`select-option-${column.title}-${rowIndex}`" @click.stop > diff --git a/packages/nc-gui/components/cell/SingleSelect.vue b/packages/nc-gui/components/cell/SingleSelect.vue index 8609ff9c34..53e7579a31 100644 --- a/packages/nc-gui/components/cell/SingleSelect.vue +++ b/packages/nc-gui/components/cell/SingleSelect.vue @@ -86,7 +86,7 @@ watch(isOpen, (n, _o) => { v-for="op of options" :key="op.title" :value="op.title" - :pw-data="`select-option-${column.title}-${rowIndex}`" + :data-nc="`select-option-${column.title}-${rowIndex}`" @click.stop > diff --git a/packages/nc-gui/components/cell/attachment/index.vue b/packages/nc-gui/components/cell/attachment/index.vue index afc6a21636..4732c1899c 100644 --- a/packages/nc-gui/components/cell/attachment/index.vue +++ b/packages/nc-gui/components/cell/attachment/index.vue @@ -160,7 +160,7 @@ watch( v-if="!isReadonly" :class="{ 'mx-auto px-4': !visibleItems.length }" class="group cursor-pointer flex gap-1 items-center active:(ring ring-accent ring-opacity-100) rounded border-1 p-1 shadow-sm hover:(bg-primary bg-opacity-10) dark:(!bg-slate-500)" - pw-data="attachment-cell-file-picker-button" + data-nc="attachment-cell-file-picker-button" @click.stop="open" > diff --git a/packages/nc-gui/components/dashboard/TreeView.vue b/packages/nc-gui/components/dashboard/TreeView.vue index c3fe34e491..b29f7a8aff 100644 --- a/packages/nc-gui/components/dashboard/TreeView.vue +++ b/packages/nc-gui/components/dashboard/TreeView.vue @@ -321,13 +321,13 @@ function openTableCreateDialog() { class="nc-tree-item text-sm cursor-pointer group" :data-order="table.order" :data-id="table.id" - :pw-data="`tree-view-table-${table.title}`" + :data-nc="`tree-view-table-${table.title}`" @click="addTableTab(table)" >
-
+
-
+
{{ $t('general.rename') }}
diff --git a/packages/nc-gui/components/dashboard/settings/AuditTab.vue b/packages/nc-gui/components/dashboard/settings/AuditTab.vue index d5f65cc31a..4cb809fbc3 100644 --- a/packages/nc-gui/components/dashboard/settings/AuditTab.vue +++ b/packages/nc-gui/components/dashboard/settings/AuditTab.vue @@ -112,7 +112,7 @@ const columns = [ :columns="columns" :pagination="false" :loading="isLoading" - data-pw="audit-tab-table" + data-nc="audit-tab-table" >