From cfa51a5b11f7d39d53fb627d7a77a925d4cb1100 Mon Sep 17 00:00:00 2001 From: Semjon Geist Date: Sun, 19 Feb 2023 19:01:47 +0100 Subject: [PATCH 01/33] add mysql to helm chart --- charts/nocodb/Chart.yaml | 4 ++++ charts/nocodb/values.yaml | 11 +++++++++++ 2 files changed, 15 insertions(+) diff --git a/charts/nocodb/Chart.yaml b/charts/nocodb/Chart.yaml index db58bf049b..afa5532f36 100644 --- a/charts/nocodb/Chart.yaml +++ b/charts/nocodb/Chart.yaml @@ -5,6 +5,10 @@ dependencies: name: postgresql repository: https://charts.bitnami.com/bitnami version: ~11.6.6 +- condition: mysql.enabled + name: mysql + repository: https://charts.bitnami.com/bitnami + version: ~9.4.6 description: A Helm chart for Kubernetes maintainers: [] name: nocodb diff --git a/charts/nocodb/values.yaml b/charts/nocodb/values.yaml index 5d7bf7887e..881e31cdbb 100644 --- a/charts/nocodb/values.yaml +++ b/charts/nocodb/values.yaml @@ -83,6 +83,7 @@ extraEnvs: extraSecretEnvs: NC_AUTH_JWT_SECRET: secretString + NC_DB: "mysql2://mysql:3306?u=nocodb&p=secretPass&d=nocodb" storage: size: 3Gi @@ -96,3 +97,13 @@ postgresql: password: secretPass persistence: size: 8Gi + +mysql: + enabled: false + auth: + database: nocodb + username: nocodb + password: secretPass + persistence: + enabled: false + size: 8Gi From bc3c591b3bf40df08927a9c72fdc54f9f2e6f874 Mon Sep 17 00:00:00 2001 From: gitstart Date: Tue, 11 Apr 2023 10:30:31 +0000 Subject: [PATCH 02/33] chores: used a better name Co-authored-by: gitstart Co-authored-by: frankmagoba Co-authored-by: gitstart_bot --- packages/nc-gui/components/smartsheet/Grid.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui/components/smartsheet/Grid.vue b/packages/nc-gui/components/smartsheet/Grid.vue index b0ba0793bd..acebc53d36 100644 --- a/packages/nc-gui/components/smartsheet/Grid.vue +++ b/packages/nc-gui/components/smartsheet/Grid.vue @@ -753,7 +753,7 @@ const closeAddColumnDropdown = () => { addColumnDropdown.value = false } -const deleteRowModal = (row: number) => { +const confirmDeleteRow = (row: number) => { Modal.confirm({ title: `Do you want to delete this row?`, wrapClassName: 'nc-modal-attachment-delete', @@ -990,7 +990,7 @@ const deleteRowModal = (row: number) => {