From 37312c566913960715293c3a11c106a2720d349a Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Fri, 29 Sep 2023 10:41:06 +0530
Subject: [PATCH] fix: i18n for Date

---
 packages/nc-gui/components/cell/DatePicker.vue            | 8 +++++---
 .../nc-gui/components/smartsheet/column/DateOptions.vue   | 2 +-
 packages/nc-gui/lang/en.json                              | 2 ++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/cell/DatePicker.vue b/packages/nc-gui/components/cell/DatePicker.vue
index 991fa52903..e1f2f79433 100644
--- a/packages/nc-gui/components/cell/DatePicker.vue
+++ b/packages/nc-gui/components/cell/DatePicker.vue
@@ -25,6 +25,8 @@ const { modelValue, isPk } = defineProps<Props>()
 
 const emit = defineEmits(['update:modelValue'])
 
+const { t } = useI18n()
+
 const { showNull } = useGlobal()
 
 const columnMeta = inject(ColumnInj, null)!
@@ -84,11 +86,11 @@ watch(
 
 const placeholder = computed(() => {
   if (isEditColumn.value && (modelValue === '' || modelValue === null)) {
-    return '(Optional)'
+    return t('labels.optional')
   } else if (modelValue === null && showNull.value) {
-    return 'NULL'
+    return t('general.null')
   } else if (isDateInvalid.value) {
-    return 'Invalid date'
+    return t('msg.invalidDate')
   } else {
     return ''
   }
diff --git a/packages/nc-gui/components/smartsheet/column/DateOptions.vue b/packages/nc-gui/components/smartsheet/column/DateOptions.vue
index c2418e40f6..9d620a5a60 100644
--- a/packages/nc-gui/components/smartsheet/column/DateOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/DateOptions.vue
@@ -16,7 +16,7 @@ if (!vModel.value.meta?.date_format) {
 </script>
 
 <template>
-  <a-form-item label="Date Format">
+  <a-form-item :label="$t('labels.dateFormat')">
     <a-select v-model:value="vModel.meta.date_format" dropdown-class-name="nc-dropdown-date-format">
       <a-select-option v-for="(format, i) of dateFormats" :key="i" :value="format">
         <div class="flex flex-row items-center">
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index c5666e6898..0a52c751e2 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -349,6 +349,7 @@
     "renameFile": "Rename File"
   },
   "labels": {
+    "dateFormat": "Date Format",
     "singularLabel": "Singular Label",
     "pluralLabel": "Plural Label",
     "optional": "Optional",
@@ -766,6 +767,7 @@
     "selectField": "Select field"
   },
   "msg": {
+    "invalidDate": "Invalid date",
     "invalidLocale": "Invalid locale",
     "invalidCurrencyCode": "Invalid Currency Code",
     "postgresHasItsOwnCurrencySettings": "PostgreSQL 'money' type has own currency settings",