Browse Source

fix(nc-gui): hide base settings sidebar if it is oss

pull/9992/head
Ramesh Mane 2 days ago
parent
commit
35bd98ff5e
  1. 2
      packages/nc-gui/components/dashboard/settings/base/index.vue
  2. 11
      tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts

2
packages/nc-gui/components/dashboard/settings/base/index.vue

@ -31,7 +31,7 @@ onMounted(() => {
<template>
<div class="flex p-5 nc-base-settings justify-center overflow-auto gap-8">
<!-- Left Pane -->
<div class="flex flex-col">
<div v-if="isEeUI" class="flex flex-col">
<div class="h-full w-60">
<div
v-if="isEeUI && hasPermissionForSnapshots"

11
tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts

@ -1,4 +1,5 @@
import { SettingsPage } from '.';
import { isEE } from '../../../setup/db';
import BasePage from '../../Base';
export class MiscSettingsPage extends BasePage {
@ -18,7 +19,10 @@ export class MiscSettingsPage extends BasePage {
}
async clickShowM2MTables() {
await this.settings.get().locator(`[data-testid="visibility-tab"]`).click();
if (isEE()) {
await this.selectTab('visibility-tab');
}
const clickAction = () => this.get().locator('.nc-settings-meta-misc-m2m').first().click();
await this.waitForResponse({
uiAction: clickAction,
@ -28,7 +32,10 @@ export class MiscSettingsPage extends BasePage {
}
async clickShowNullEmptyFilters() {
await this.settings.get().locator(`[data-testid="visibility-tab"]`).click();
if (isEE()) {
await this.selectTab('visibility-tab');
}
await this.waitForResponse({
uiAction: () => this.rootPage.locator('.nc-settings-show-null-and-empty-in-filter').first().click(),
requestUrlPathToMatch: '/api/v1/db/meta/projects',

Loading…
Cancel
Save