From 35bd98ff5e4b1d6eb0aa5b94b39fe4a5e6088f05 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Mon, 9 Dec 2024 21:49:12 +0530
Subject: [PATCH] fix(nc-gui): hide base settings sidebar if it is oss

---
 .../components/dashboard/settings/base/index.vue      |  2 +-
 .../pages/Dashboard/Settings/Miscellaneous.ts         | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/settings/base/index.vue b/packages/nc-gui/components/dashboard/settings/base/index.vue
index c3212dd5af..68d6a40f14 100644
--- a/packages/nc-gui/components/dashboard/settings/base/index.vue
+++ b/packages/nc-gui/components/dashboard/settings/base/index.vue
@@ -31,7 +31,7 @@ onMounted(() => {
 <template>
   <div class="flex p-5 nc-base-settings justify-center overflow-auto gap-8">
     <!-- Left Pane -->
-    <div class="flex flex-col">
+    <div v-if="isEeUI" class="flex flex-col">
       <div class="h-full w-60">
         <div
           v-if="isEeUI && hasPermissionForSnapshots"
diff --git a/tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts b/tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts
index e7b0906061..346d16ff5e 100644
--- a/tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts
+++ b/tests/playwright/pages/Dashboard/Settings/Miscellaneous.ts
@@ -1,4 +1,5 @@
 import { SettingsPage } from '.';
+import { isEE } from '../../../setup/db';
 import BasePage from '../../Base';
 
 export class MiscSettingsPage extends BasePage {
@@ -18,7 +19,10 @@ export class MiscSettingsPage extends BasePage {
   }
 
   async clickShowM2MTables() {
-    await this.settings.get().locator(`[data-testid="visibility-tab"]`).click();
+    if (isEE()) {
+      await this.selectTab('visibility-tab');
+    }
+
     const clickAction = () => this.get().locator('.nc-settings-meta-misc-m2m').first().click();
     await this.waitForResponse({
       uiAction: clickAction,
@@ -28,7 +32,10 @@ export class MiscSettingsPage extends BasePage {
   }
 
   async clickShowNullEmptyFilters() {
-    await this.settings.get().locator(`[data-testid="visibility-tab"]`).click();
+    if (isEE()) {
+      await this.selectTab('visibility-tab');
+    }
+
     await this.waitForResponse({
       uiAction: () => this.rootPage.locator('.nc-settings-show-null-and-empty-in-filter').first().click(),
       requestUrlPathToMatch: '/api/v1/db/meta/projects',