From 349e0c64d22df769d259830d88ceb50615cfeeb9 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Thu, 26 Oct 2023 17:05:38 +0000
Subject: [PATCH] fix: Removed manual auto scrolling as its not required since
 browser list maintains its scroll position of item even if top items are
 removed if there space to scroll top

---
 packages/nc-gui/components/dashboard/Sidebar.vue       | 10 +---------
 .../components/dashboard/TreeView/ProjectNode.vue      |  8 ++------
 .../nc-gui/components/dashboard/TreeView/TableList.vue |  5 -----
 .../nc-gui/components/dashboard/TreeView/TableNode.vue |  2 --
 .../nc-gui/components/dashboard/TreeView/index.vue     |  6 +-----
 5 files changed, 4 insertions(+), 27 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/Sidebar.vue b/packages/nc-gui/components/dashboard/Sidebar.vue
index ad3af0e9cf..2b2c9a6551 100644
--- a/packages/nc-gui/components/dashboard/Sidebar.vue
+++ b/packages/nc-gui/components/dashboard/Sidebar.vue
@@ -31,14 +31,6 @@ onMounted(() => {
 onUnmounted(() => {
   treeViewDom.value?.removeEventListener('scroll', checkScrollTopMoreThanZero)
 })
-
-const onOpenTable = (scrollDown: boolean) => {
-  if (scrollDown && treeViewDom.value && !isMobileMode.value) {
-    nextTick(() => {
-      treeViewDom.value!.scrollTop = treeViewDom.value!.scrollTop - 8
-    })
-  }
-}
 </script>
 
 <template>
@@ -62,7 +54,7 @@ const onOpenTable = (scrollDown: boolean) => {
         'pt-0.25': isSharedBase,
       }"
     >
-      <DashboardTreeView v-if="!isWorkspaceLoading" @open-table="onOpenTable" />
+      <DashboardTreeView v-if="!isWorkspaceLoading" />
     </div>
     <div v-if="!isSharedBase">
       <DashboardSidebarUserInfo />
diff --git a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
index ef258c2954..6333bc5513 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
@@ -365,10 +365,6 @@ const projectDelete = () => {
   isProjectDeleteDialogVisible.value = true
   $e('c:project:delete')
 }
-
-const onOpenTable = (scrollDown: boolean) => {
-  emit('openTable', scrollDown)
-}
 </script>
 
 <template>
@@ -588,7 +584,7 @@ const onOpenTable = (scrollDown: boolean) => {
           <div class="flex-1 overflow-y-auto overflow-x-hidden flex flex-col" :class="{ 'mb-[20px]': isSharedBase }">
             <div v-if="base?.sources?.[0]?.enabled" class="flex-1">
               <div class="transition-height duration-200">
-                <DashboardTreeViewTableList :base="base" :source-index="0" @open-table="onOpenTable" />
+                <DashboardTreeViewTableList :base="base" :source-index="0" />
               </div>
             </div>
 
@@ -702,7 +698,7 @@ const onOpenTable = (scrollDown: boolean) => {
                         :key="`sortable-${source.id}-${source.id && source.id in keys ? keys[source.id] : '0'}`"
                         :nc-source="source.id"
                       >
-                        <DashboardTreeViewTableList :base="base" :source-index="sourceIndex" @open-table="onOpenTable" />
+                        <DashboardTreeViewTableList :base="base" :source-index="sourceIndex" />
                       </div>
                     </a-collapse-panel>
                   </a-collapse>
diff --git a/packages/nc-gui/components/dashboard/TreeView/TableList.vue b/packages/nc-gui/components/dashboard/TreeView/TableList.vue
index f183314196..dc0f3aebe8 100644
--- a/packages/nc-gui/components/dashboard/TreeView/TableList.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/TableList.vue
@@ -131,10 +131,6 @@ watchEffect(() => {
 const availableTables = computed(() => {
   return tables.value.filter((table) => table.source_id === base.value?.sources?.[sourceIndex.value].id)
 })
-
-const onOpenTable = (scrollDown: boolean) => {
-  emit('openTable', scrollDown)
-}
 </script>
 
 <template>
@@ -168,7 +164,6 @@ const onOpenTable = (scrollDown: boolean) => {
           :data-title="table.title"
           :data-source-id="source?.id"
           :data-type="table.type"
-          @open-table="onOpenTable"
         >
         </TableNode>
       </div>
diff --git a/packages/nc-gui/components/dashboard/TreeView/TableNode.vue b/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
index 9ba6b50641..75fe2dca6f 100644
--- a/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
@@ -122,8 +122,6 @@ const onOpenTable = async () => {
     if (isMobileMode.value) {
       isLeftSidebarOpen.value = false
     }
-
-    if (!showCreateViewAllTimes.value) emit('openTable', true)
   } catch (e) {
     message.error(await extractSdkResponseErrorMsg(e))
   } finally {
diff --git a/packages/nc-gui/components/dashboard/TreeView/index.vue b/packages/nc-gui/components/dashboard/TreeView/index.vue
index 1b2df7c4c4..376a0222a6 100644
--- a/packages/nc-gui/components/dashboard/TreeView/index.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/index.vue
@@ -223,10 +223,6 @@ watch(
     immediate: true,
   },
 )
-
-const onOpenTable = (scrollDown: boolean) => {
-  emit('openTable', scrollDown)
-}
 </script>
 
 <template>
@@ -235,7 +231,7 @@ const onOpenTable = (scrollDown: boolean) => {
     <div mode="inline" class="nc-treeview pb-0.5 flex-grow min-h-50 overflow-x-hidden">
       <template v-if="basesList?.length">
         <ProjectWrapper v-for="base of basesList" :key="base.id" :base-role="base.project_role" :base="base">
-          <DashboardTreeViewProjectNode @open-table="onOpenTable" />
+          <DashboardTreeViewProjectNode />
         </ProjectWrapper>
       </template>