From 33f5fce87de5e0bede703e1723f5c80cc21917d6 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Mon, 1 Aug 2022 12:01:49 +0800
Subject: [PATCH] feat(gui-v2): Formula Cell

---
 .../components/virtual-cell/Formula.vue       | 42 ++++++-------------
 1 file changed, 12 insertions(+), 30 deletions(-)

diff --git a/packages/nc-gui-v2/components/virtual-cell/Formula.vue b/packages/nc-gui-v2/components/virtual-cell/Formula.vue
index a32011b359..1e93f6ba00 100644
--- a/packages/nc-gui-v2/components/virtual-cell/Formula.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/Formula.vue
@@ -5,6 +5,7 @@ import { handleTZ } from '~/utils/dateTimeUtils'
 import { replaceUrlsWithLink } from '~/utils/urlUtils'
 
 const column = inject(ColumnInj)
+
 const value = inject('value')
 
 const { isPg } = useProject()
@@ -18,32 +19,23 @@ const showEditFormulaWarningMessage = () => {
   }, 3000)
 }
 
-const result = computed(() => {
-  if (isPg) {
-    return handleTZ(value)
-  }
-  return value
-})
+const result = computed(() => (isPg ? handleTZ(value) : value))
 
-const urls = computed(() => {
-  return replaceUrlsWithLink(result.value)
-})
+const urls = computed(() => replaceUrlsWithLink(result.value))
 </script>
 
 <template>
   <div>
-    <v-tooltip v-if="column && column.colOptions && column.colOptions.error" bottom color="error">
-      <template #activator="{ on }">
-        <span class="caption" v-on="on">ERR<span class="error--text">!</span></span>
+    <a-tooltip v-if="column && column.colOptions && column.colOptions.error" placement="bottom" class="text-orange-700">
+      <template #title>
+        <span class="font-bold">{{ column.colOptions.error }}</span>
       </template>
-      <span class="font-weight-bold">{{ column.colOptions.error }}</span>
-    </v-tooltip>
-    <div class="formula-cell-wrapper" @dblclick="showEditFormulaWarningMessage">
+      <span>ERR!</span>
+    </a-tooltip>
+    <div class="pa-2" @dblclick="showEditFormulaWarningMessage">
       <div v-if="urls" v-html="urls" />
-      <div v-else>
-        {{ result }}
-      </div>
-      <div v-if="showEditFormulaWarning" class="edit-warning">
+      <div v-else>{{ result }}</div>
+      <div v-if="showEditFormulaWarning" class="text-left mt-2 text-[#e65100]">
         <!-- TODO: i18n -->
         Warning: Formula fields should be configured in the field menu dropdown.
       </div>
@@ -51,14 +43,4 @@ const urls = computed(() => {
   </div>
 </template>
 
-<style scoped>
-.formula-cell-wrapper {
-  padding: 10px;
-}
-
-.edit-warning {
-  text-align: left;
-  margin-top: 10px;
-  color: #e65100;
-}
-</style>
+<style scoped></style>