From 30d4edc3dfbbaa6988d180debb81caf3b2303c55 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Tue, 12 Mar 2024 06:44:57 +0000
Subject: [PATCH] fix(nc-gui): update base icon color picker  model with new
 design

---
 .../general/BaseIconColorPicker.vue           | 138 +++++++-----------
 ...iderWrapper.vue => ColorSliderWrapper.vue} |  18 ++-
 packages/nc-gui/lang/en.json                  |   2 +-
 packages/nc-gui/store/bases.ts                |   1 +
 4 files changed, 65 insertions(+), 94 deletions(-)
 rename packages/nc-gui/components/general/{ColorHueSliderWrapper.vue => ColorSliderWrapper.vue} (62%)

diff --git a/packages/nc-gui/components/general/BaseIconColorPicker.vue b/packages/nc-gui/components/general/BaseIconColorPicker.vue
index 72a91bcabd..316358b558 100644
--- a/packages/nc-gui/components/general/BaseIconColorPicker.vue
+++ b/packages/nc-gui/components/general/BaseIconColorPicker.vue
@@ -16,28 +16,29 @@ const emit = defineEmits(['colorSelected'])
 const { hue, size = 'medium', readonly } = props
 
 const defaultHueColor = {
-  h: 0,
-  s: 0,
-  v: 0,
+  h: 199,
+  s: 79,
+  v: 100,
 }
 
 const defaultHueValue = 199
 
 const isOpen = ref(false)
 
-const isOpenHuePicker = ref(false)
-
 const colorRef = ref({
   ...defaultHueColor,
   h: !(hue !== 0 && !hue) ? hue : defaultHueValue,
 })
 
+const updateColorHue = (value?: string | number | null) => {
+  colorRef.value.h = !isNaN(parseInt(`${value}`)) ? +Math.min(parseInt(`${value}`), 360) : 0
+}
+
 function selectColor(value: number) {
   colorRef.value.h = value
 
   emit('colorSelected', value)
 
-  isOpenHuePicker.value = false
   isOpen.value = false
 }
 
@@ -50,14 +51,10 @@ const onClick = (e: Event) => {
 }
 
 watch(
-  isOpenHuePicker,
-  () => {
-    if (!isOpenHuePicker.value && colorRef.value.h !== hue) {
-      if (hue !== 0 && !hue) {
-        colorRef.value.h = defaultHueValue
-      } else {
-        colorRef.value.h = hue
-      }
+  isOpen,
+  (value) => {
+    if (!value && colorRef.value.h !== hue) {
+      emit('colorSelected', colorRef.value.h)
     }
   },
   {
@@ -130,15 +127,12 @@ watch(
       </template>
     </div>
     <template #overlay>
-      <div class="relative bg-white rounded-lg p-3 border-1 border-gray-200 shadow-lg">
-        <div class="w-[164px] flex flex-wrap">
+      <div class="relative bg-white rounded-lg border-1 border-gray-200 shadow-lg">
+        <div class="flex items-center p-2 space-x-2">
           <div
             v-for="(h, i) of Object.keys(preDefinedHueData)"
             :key="i"
             class="nc-pre-defined-hue-item p-1 rounded cursor-pointer hover:bg-gray-200"
-            :class="{
-              'mt-3': i > 4,
-            }"
           >
             <div
               class="rounded h-6 w-6"
@@ -151,55 +145,35 @@ watch(
               @click="selectColor(preDefinedHueData[h].tint.h)"
             ></div>
           </div>
+        </div>
 
-          <a-dropdown
-            v-model:visible="isOpenHuePicker"
-            :trigger="['click']"
-            :disabled="readonly"
-            placement="bottom"
-            overlay-class-name="!left-9"
-          >
-            <div
-              class="nc-custom-hue-picker-item p-1 rounded cursor-pointer hover:bg-gray-200 mt-3"
-              :class="{
-                'bg-gray-200': isOpenHuePicker,
-              }"
-            >
-              <div
-                class="rounded overflow-hidden h-6 w-6"
-                :class="{
-                  selected: hue !== undefined && hue !== null && !preDefinedHueData[`_${hue}`],
-                }"
-                :style="{
-                  backgroundColor: tinycolor(`hsv(${hue}, 30%, 100%) `).toHexString(),
-                }"
-              >
-                <img src="~/assets/img/hue-colors.png" class="" alt="Hue picker" />
-              </div>
-            </div>
-            <template #overlay>
-              <div class="relative bg-white rounded-lg p-3 border-1 border-gray-200 shadow-lg flex flex-col space-y-4">
-                <div>{{ $t('labels.customHue') }}</div>
-                
-                <LazyGeneralColorHueSliderWrapper
-                  :model-value="colorRef"
-                  @update:model-value="
-                    (value) => {
-                      if (value?.h !== 0 && !value?.h) return
-
-                      colorRef.h = value.h
-                    }
-                  "
-                />
-
-                <div class="flex items-center justify-end">
-                  <NcButton type="secondary" size="small" @click="selectColor(colorRef.h ?? defaultHueValue)">
-                    {{ $t('general.apply') }}
-                  </NcButton>
-                </div>
-              </div>
-            </template>
-          </a-dropdown>
+        <div class="p-2 border-t-1 border-gray-200 flex flex-col space-y-4">
+          <div class="uppercase text-xs font-medium">{{ $t('labels.customColour') }}</div>
+
+          <div class="flex flex-row items-center gap-x-3">
+            <input
+              :value="parseInt(`${colorRef.h ?? 0}`)"
+              class="nc-color-hue-input"
+              type="number"
+              @input="
+                (value) => {
+                  updateColorHue(value.target?.value)
+                }
+              "
+              :min="0"
+              :max="360"
+            />
+
+            <LazyGeneralColorSliderWrapper
+              :model-value="colorRef"
+              class="!min-w-none ml-3"
+              @update:model-value="
+                (value) => {
+                  updateColorHue(value?.h)
+                }
+              "
+            />
+          </div>
         </div>
       </div>
     </template>
@@ -214,25 +188,19 @@ watch(
   }
 }
 
-:deep(.nc-hue-color-picker) {
-  &.vc-slider {
-    width: 297px;
-  }
-  .vc-slider-swatches {
-    @apply hidden;
-  }
-  .vc-hue {
-    @apply rounded-lg;
+.nc-color-hue-input {
+  @apply outline-none text-sm rounded-lg border-gray-200 py-1 px-3 w-14 text-center;
+  -moz-appearance: textfield;
+
+  &:focus {
+    @apply ring-transparent border-brand-500;
   }
-  .vc-slider-hue-warp {
-    height: 6px;
-    .vc-hue-pointer {
-      top: -3px !important;
-    }
-    .vc-hue-picker {
-      background-color: white;
-      box-shadow: 0 0 0 3px var(--nc-hue-slider-pointer-color) !important;
-    }
+
+  /* Chrome, Safari, Edge, Opera */
+  &::-webkit-outer-spin-button,
+  &::-webkit-inner-spin-button {
+    -webkit-appearance: none;
+    margin: 0;
   }
 }
 </style>
diff --git a/packages/nc-gui/components/general/ColorHueSliderWrapper.vue b/packages/nc-gui/components/general/ColorSliderWrapper.vue
similarity index 62%
rename from packages/nc-gui/components/general/ColorHueSliderWrapper.vue
rename to packages/nc-gui/components/general/ColorSliderWrapper.vue
index 500dfc87a8..3ac7f7a7c1 100644
--- a/packages/nc-gui/components/general/ColorHueSliderWrapper.vue
+++ b/packages/nc-gui/components/general/ColorSliderWrapper.vue
@@ -8,17 +8,19 @@ interface Props {
 }
 
 const props = withDefaults(defineProps<Props>(), {
-  modelValue: () => ({ h: 199, s: 0, v: 0 }),
+  modelValue: () => '#3069FE',
   mode: () => 'hsv',
 })
 
 const emit = defineEmits(['update:modelValue', 'input'])
 
 const picked = computed({
-  get: () => props.modelValue || { h: 199, s: 0, v: 0 },
+  get: () => tinycolor(props.modelValue || '#3069FE').toHsv() as any,
   set: (val) => {
-    emit('update:modelValue', val[props.mode] || null)
-    emit('input', val[props.mode] || null)
+    if (val) {
+      emit('update:modelValue', val[props.mode] || null)
+      emit('input', val[props.mode] || null)
+    }
   },
 })
 </script>
@@ -26,15 +28,15 @@ const picked = computed({
 <template>
   <Slider
     v-model="picked"
-    class="nc-hue-slider-wrapper min-w-[200px]"
+    class="nc-color-slider-wrapper min-w-[200px]"
     :style="{
-      ['--nc-hue-slider-pointer-color']: tinycolor(`hsv(${picked.h ?? 199}, 100%, 100%)`).toHexString(),
+      ['--nc-color-slider-pointer']: tinycolor(`hsv(${picked.h ?? 199}, 100%, 100%)`).toHexString(),
     }"
   />
 </template>
 
 <style lang="scss" scoped>
-.nc-hue-slider-wrapper {
+.nc-color-slider-wrapper {
   &.vc-slider {
     @apply !w-full;
   }
@@ -52,7 +54,7 @@ const picked = computed({
     }
     .vc-hue-picker {
       background-color: white;
-      box-shadow: 0 0 0 3px var(--nc-hue-slider-pointer-color) !important;
+      box-shadow: 0 0 0 3px var(--nc-color-slider-pointer) !important;
     }
   }
 }
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 93783fee1b..3182ef6537 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -700,7 +700,7 @@
     "limitOptions": "Limit ptions",
     "limitOptionsSubtext": "Limit options visible to users by selecting available options",
     "clearSelection": "Clear selection",
-    "customHue": "Custom Hue"
+    "customColour": "Custom colour"
   },
   "activity": {
     "noRange": "Calendar view requires a date range",
diff --git a/packages/nc-gui/store/bases.ts b/packages/nc-gui/store/bases.ts
index 69c720115b..f16ea12753 100644
--- a/packages/nc-gui/store/bases.ts
+++ b/packages/nc-gui/store/bases.ts
@@ -201,6 +201,7 @@ export const useBases = defineStore('basesStore', () => {
       isExpanded: route.value.params.baseId === baseId || existingProject.isExpanded,
       // isLoading is managed by Sidebar
       isLoading: existingProject.isLoading,
+      meta: { ...parseProp(existingProject.meta), ...parseProp(_project.meta) },
     }
 
     bases.value.set(baseId, base)