diff --git a/packages/nc-gui/extensions/data-exporter/index.vue b/packages/nc-gui/extensions/data-exporter/index.vue index 22e8761e86..06aeb8ca6e 100644 --- a/packages/nc-gui/extensions/data-exporter/index.vue +++ b/packages/nc-gui/extensions/data-exporter/index.vue @@ -296,12 +296,66 @@ onMounted(async () => { 'bg-white': fullscreen, }" > -
+
+
+
Separator
+ + + +
+ + + {{ delimiter.label }} + + +
+
+
+
+
+
+
Encoding
+ + + +
+ + + {{ encoding.label }} + + +
+
+
+
+
+
+
-
-
Separator
- - - -
- - - {{ delimiter.label }} - - -
-
-
-
-
-
-
Encoding
- - - -
- - - {{ encoding.label }} - - -
-
-
-
-
-
{ diff --git a/packages/nocodb/src/interface/Jobs.ts b/packages/nocodb/src/interface/Jobs.ts index b2279427dd..dc35529997 100644 --- a/packages/nocodb/src/interface/Jobs.ts +++ b/packages/nocodb/src/interface/Jobs.ts @@ -1,4 +1,4 @@ -import type { AttachmentResType, PublicAttachmentScope, UserType } from 'nocodb-sdk'; +import type { AttachmentResType, PublicAttachmentScope, SupportedExportCharset, UserType } from 'nocodb-sdk'; import type { NcContext, NcRequest } from '~/interface/config'; export const JOBS_QUEUE = 'jobs'; @@ -152,7 +152,7 @@ export interface DataExportJobData extends JobData { options?: { delimiter?: string; extension_id?: string; - encoding?: BufferEncoding; + encoding?: SupportedExportCharset; }; modelId: string; viewId: string; diff --git a/packages/nocodb/src/modules/jobs/jobs/data-export/data-export.processor.ts b/packages/nocodb/src/modules/jobs/jobs/data-export/data-export.processor.ts index dfd3f1511e..f1b0c55237 100644 --- a/packages/nocodb/src/modules/jobs/jobs/data-export/data-export.processor.ts +++ b/packages/nocodb/src/modules/jobs/jobs/data-export/data-export.processor.ts @@ -89,7 +89,6 @@ export class DataExportProcessor { viewId: view.id, ncSiteUrl: ncSiteUrl, delimiter: options?.delimiter, - encoding: options?.encoding || 'utf-8', }) .catch((e) => { this.logger.debug(e); diff --git a/packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts b/packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts index b9301b3b63..06214a8059 100644 --- a/packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts +++ b/packages/nocodb/src/modules/jobs/jobs/export-import/export.service.ts @@ -461,7 +461,6 @@ export class ExportService { _fieldIds?: string[]; ncSiteUrl?: string; delimiter?: string; - encoding?: BufferEncoding; }, ) { const { dataStream, linkStream, handledMmList } = param;