diff --git a/packages/nc-gui/components/account/Token.vue b/packages/nc-gui/components/account/Token.vue index e7338bdcde..6690c4b63a 100644 --- a/packages/nc-gui/components/account/Token.vue +++ b/packages/nc-gui/components/account/Token.vue @@ -3,6 +3,7 @@ import type { VNodeRef } from '@vue/runtime-core' import { message } from 'ant-design-vue' import type { ApiTokenType, RequestParams } from 'nocodb-sdk' import { extractSdkResponseErrorMsg, isEeUI, ref, useApi, useCopy, useNuxtApp } from '#imports' +import { extractNextDefaultName } from '~/helpers/parsers/parserHelpers' const { api, isLoading } = useApi() @@ -42,28 +43,8 @@ const pagination = reactive({ pageSize: 10, }) -const getDefaultTokenValue = (tokens: IApiTokenInfo[]) => { - let extractedSortedTokenNumbers = - [...tokens] - .map((e) => { - let tokenName = e.description?.split('-') - if (tokenName && tokenName[tokenName.length - 1] && !isNaN(Number(tokenName[tokenName.length - 1]?.trim()))) { - return Number(tokenName[tokenName.length - 1]?.trim()) - } - }) - .filter((e) => e) - .sort((a, b) => { - if (a !== undefined && b !== undefined) { - return a - b - } - return 0 - }) || [] - - if (extractedSortedTokenNumbers.length) { - return `${defaultTokenName}-${(extractedSortedTokenNumbers[extractedSortedTokenNumbers.length - 1] || 0) + 1}` - } else { - return `${defaultTokenName}-1` - } +const getDefaultTokenName = (tokens: IApiTokenInfo[]) => { + return extractNextDefaultName([...tokens.map((el) => el?.description || '')], defaultTokenName) } const hideOrShowToken = (tokenId: string) => { @@ -91,7 +72,7 @@ const loadTokens = async (page = currentPage.value, limit = currentLimit.value) pagination.pageSize = 10 tokens.value = response.list as IApiTokenInfo[] - selectedTokenData.value.description = getDefaultTokenValue(tokens.value) + selectedTokenData.value.description = getDefaultTokenName(tokens.value) } catch (e: any) { message.error(await extractSdkResponseErrorMsg(e)) } diff --git a/packages/nc-gui/components/smartsheet/grid/Table.vue b/packages/nc-gui/components/smartsheet/grid/Table.vue index 42dcfb3406..e762a9d8c5 100644 --- a/packages/nc-gui/components/smartsheet/grid/Table.vue +++ b/packages/nc-gui/components/smartsheet/grid/Table.vue @@ -1703,7 +1703,7 @@ onKeyStroke('ArrowDown', onDown) (isLinksOrLTAR(fields[contextMenuTarget.col]) || !isVirtualCol(fields[contextMenuTarget.col])) " class="nc-base-menu-item" - :disabled="!!isSystemColumn(fields[contextMenuTarget.col])" + :disabled="isSystemColumn(fields[contextMenuTarget.col])" @click="clearCell(contextMenuTarget)" >
@@ -1717,7 +1717,7 @@ onKeyStroke('ArrowDown', onDown) v-else-if="contextMenuTarget && hasEditPermission" class="nc-base-menu-item" @click="clearSelectedRangeOfCells()" - :disabled="!!isSystemColumn(fields[contextMenuTarget.col])" + :disabled="isSystemColumn(fields[contextMenuTarget.col])" >
diff --git a/packages/nc-gui/components/smartsheet/header/Cell.vue b/packages/nc-gui/components/smartsheet/header/Cell.vue index 5db5748dec..886074e4b8 100644 --- a/packages/nc-gui/components/smartsheet/header/Cell.vue +++ b/packages/nc-gui/components/smartsheet/header/Cell.vue @@ -49,7 +49,7 @@ const closeAddColumnDropdown = () => { } const openHeaderMenu = () => { - if (isLocked.value || (!!isSystemColumn(column.value) && column.value.uidt !== UITypes.ID)) return + if (isLocked.value || (isSystemColumn(column.value) && column.value.uidt !== UITypes.ID)) return if (!isForm.value && !isExpandedForm.value && isUIAllowed('fieldEdit') && !isMobileMode.value) { editColumnDropdown.value = true diff --git a/packages/nc-gui/components/smartsheet/header/Menu.vue b/packages/nc-gui/components/smartsheet/header/Menu.vue index 088a9c023d..565a65212d 100644 --- a/packages/nc-gui/components/smartsheet/header/Menu.vue +++ b/packages/nc-gui/components/smartsheet/header/Menu.vue @@ -292,7 +292,7 @@ const onInsertAfter = () => {