Browse Source

fix: raw bulk insert

pull/7727/head
mertmit 10 months ago
parent
commit
265817e018
  1. 14
      packages/nocodb/src/db/BaseModelSqlv2.ts

14
packages/nocodb/src/db/BaseModelSqlv2.ts

@ -3039,6 +3039,8 @@ class BaseModelSqlv2 {
// TODO: ag column handling for raw bulk insert
const insertDatas = raw ? datas : [];
let postInsertOps: ((rowId: any, trx?: any) => Promise<void>)[] = [];
let aiPkCol: Column;
let agPkCol: Column;
if (!raw) {
const nestedCols = (await this.model.getColumns()).filter((c) =>
@ -3194,6 +3196,9 @@ class BaseModelSqlv2 {
insertDatas.push(insertObj);
}
aiPkCol = this.model.primaryKeys.find((pk) => pk.ai);
agPkCol = this.model.primaryKeys.find((pk) => pk.meta?.ag);
}
if ('beforeBulkInsert' in this) {
@ -3219,9 +3224,6 @@ class BaseModelSqlv2 {
let responses;
const aiPkCol = this.model.primaryKeys.find((pk) => pk.ai);
const agPkCol = this.model.primaryKeys.find((pk) => pk.meta?.ag);
// insert one by one as fallback to get ids for sqlite and mysql
if (insertOneByOneAsFallback && (this.isSqlite || this.isMySQL)) {
// sqlite and mysql doesn't support returning, so insert one by one and return ids
@ -3248,8 +3250,10 @@ class BaseModelSqlv2 {
} else {
const returningArr: string[] = [];
for (const col of this.model.primaryKeys) {
returningArr.push(col.column_name);
if (!raw) {
for (const col of this.model.primaryKeys) {
returningArr.push(col.column_name);
}
}
responses =

Loading…
Cancel
Save