From 25db00bff963c17bff735e2688e6f65e2f88a428 Mon Sep 17 00:00:00 2001
From: Anbarasu <anbarasun123@gmail.com>
Date: Thu, 30 May 2024 16:14:58 +0530
Subject: [PATCH] fix: throw error if invalid operator used in xcCondition
 (#8568)

* fix: throw error if invalid operator used in xcCondition

* fix: update error message

* fix: use NcError

* fix: use NcError

* fix: use metaError
---
 packages/nocodb/src/db/CustomKnex.ts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/packages/nocodb/src/db/CustomKnex.ts b/packages/nocodb/src/db/CustomKnex.ts
index 9077ba8109..c5aed6d4db 100644
--- a/packages/nocodb/src/db/CustomKnex.ts
+++ b/packages/nocodb/src/db/CustomKnex.ts
@@ -4,6 +4,7 @@ import dayjs from 'dayjs';
 import type { FilterType } from 'nocodb-sdk';
 import type { BaseModelSql } from '~/db/BaseModelSql';
 import Filter from '~/models/Filter';
+import { NcError } from '~/helpers/catchError';
 
 // refer : https://github.com/brianc/node-pg-types/blob/master/lib/builtins.js
 const pgTypes = {
@@ -691,6 +692,11 @@ const parseCondition = (obj, columnAliases, qb, pKey?) => {
             case 'nin':
               qb = qb.whereNotIn(fieldName, val);
               break;
+            default:
+              NcError.metaError({
+                message: `Found invalid conditional operator "${key}" in expression`,
+                sql: '',
+              });
           }
         }
         break;