From 21c2ff8af923bd8d2b9a7b0d33371aaf5d7a4224 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 12 Jul 2024 18:22:06 +0000
Subject: [PATCH] fix: exclude unsupported columns

---
 .../column/LinkedToAnotherRecordOptions.vue   | 22 ++++++++++++++++---
 .../components/smartsheet/header/Menu.vue     | 14 +++++++++---
 2 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
index ce5ce260e3..9b3d485414 100644
--- a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
@@ -47,9 +47,18 @@ if (!isEdit.value) {
   if (!vModel.value.onDelete) vModel.value.onDelete = onUpdateDeleteOptions[0]
   if (!vModel.value.virtual) vModel.value.virtual = sqlUi === SqliteUi // appInfo.isCloud || sqlUi === SqliteUi
   if (!vModel.value.alias) vModel.value.alias = vModel.value.column_name
+} else {
+  if (!vModel.value.childId)
+    vModel.custom = {
+      ref_model_id: vModel.value?.colOptions?.fk_related_model_id,
+      base_id: meta.value?.base_id,
+      junc_base_id: meta.value?.base_id,
+    }
+  if (!vModel.value.childViewId) vModel.value.childViewId = vModel.value?.colOptions?.fk_target_view_id || null
 }
 if (!vModel.value.childId) vModel.value.childId = vModel.value?.colOptions?.fk_related_model_id || null
 if (!vModel.value.childViewId) vModel.value.childViewId = vModel.value?.colOptions?.fk_target_view_id || null
+if (!vModel.value.type) vModel.value.type = vModel.value?.colOptions?.type || 'mm'
 
 const advancedOptions = ref(false)
 
@@ -221,11 +230,18 @@ const handleShowAdvanceOptions = () => {
       </a-form-item>
     </div>
     <div v-if="isAdvancedOptionsShownEasterEgg && isEeUI">
-      <a-switch v-model:checked="vModel.is_custom_link" size="small" name="Custom" @change="onCustomSwitchToggle" />
+      <a-switch
+        v-model:checked="vModel.is_custom_link"
+        :disabled="isEdit"
+        :is-edit="isEdit"
+        size="small"
+        name="Custom"
+        @change="onCustomSwitchToggle"
+      />
       <span class="ml-3">Advanced Link</span>
     </div>
-    <div v-if="isEeUI && vModel.is_custom_link" :class="{}">
-      <LazySmartsheetColumnLinkAdvancedOptions v-model:value="vModel" :meta="meta" />
+    <div v-if="isEeUI && vModel.is_custom_link">
+      <LazySmartsheetColumnLinkAdvancedOptions v-model:value="vModel" :is-edit="isEdit" :meta="meta" />
     </div>
     <template v-else>
       <a-form-item class="flex w-full pb-2 nc-ltar-child-table" v-bind="validateInfos.childId">
diff --git a/packages/nc-gui/components/smartsheet/header/Menu.vue b/packages/nc-gui/components/smartsheet/header/Menu.vue
index 5749ec8609..7b1aa6f119 100644
--- a/packages/nc-gui/components/smartsheet/header/Menu.vue
+++ b/packages/nc-gui/components/smartsheet/header/Menu.vue
@@ -374,6 +374,13 @@ const isColumnEditAllowed = computed(() => {
     return false
   return true
 })
+
+// check if the column is associated as foreign key in any of the link column
+const linksAssociated = computed(() => {
+  return meta.value?.columns?.filter(
+    (c) => isLinksOrLTAR(c) && [c.colOptions?.fk_child_column_id, c.colOptions?.fk_parent_column_id].includes(column?.value?.id),
+  )
+})
 </script>
 
 <template>
@@ -399,7 +406,8 @@ const isColumnEditAllowed = computed(() => {
         <GeneralSourceRestrictionTooltip message="Field properties cannot be edited." :enabled="!isColumnEditAllowed">
           <NcMenuItem
             v-if="isUIAllowed('fieldAlter')"
-            :disabled="column?.pk || isSystemColumn(column) || !isColumnEditAllowed"
+            :disabled="column?.pk || isSystemColumn(column) || !isColumnEditAllowed || linksAssociated.length"
+            :title="linksAssociated.length ? 'Field is associated with a link column' : undefined"
             @click="onEditPress"
           >
             <div class="nc-column-edit nc-header-menu-item">
@@ -409,7 +417,6 @@ const isColumnEditAllowed = computed(() => {
             </div>
           </NcMenuItem>
         </GeneralSourceRestrictionTooltip>
-
         <GeneralSourceRestrictionTooltip message="Field cannot be duplicated." :enabled="!isDuplicateAllowed">
           <NcMenuItem
             v-if="isUIAllowed('duplicateColumn') && isExpandedForm && !column?.pk"
@@ -554,8 +561,9 @@ const isColumnEditAllowed = computed(() => {
         <GeneralSourceRestrictionTooltip message="Field cannot be deleted." :enabled="!isColumnUpdateAllowed">
           <NcMenuItem
             v-if="!column?.pv && isUIAllowed('fieldDelete')"
-            :disabled="!isDeleteAllowed || !isColumnUpdateAllowed"
+            :disabled="!isDeleteAllowed || !isColumnUpdateAllowed || linksAssociated.length"
             class="!hover:bg-red-50"
+            :title="linksAssociated ? 'Field is associated with a link column' : undefined"
             @click="handleDelete"
           >
             <div