From 2168aff54b81ddbea5e3c41aacf247ec4525f761 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Wed, 20 Dec 2023 12:04:52 +0000
Subject: [PATCH] fix: if no filter trigger on all change

---
 packages/nocodb/src/helpers/webhookHelpers.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/nocodb/src/helpers/webhookHelpers.ts b/packages/nocodb/src/helpers/webhookHelpers.ts
index 26dc2fd532..f143f9ec75 100644
--- a/packages/nocodb/src/helpers/webhookHelpers.ts
+++ b/packages/nocodb/src/helpers/webhookHelpers.ts
@@ -301,6 +301,8 @@ export async function invokeWebhook(
     }
 
     if (hook.condition && !testHook) {
+      const filters = testFilters || (await hook.getFilters());
+
       if (isBulkOperation) {
         const filteredData = [];
         for (let i = 0; i < newData.length; i++) {
@@ -308,12 +310,11 @@ export async function invokeWebhook(
           const pData = prevData[i] ? prevData[i] : null;
 
           // if condition is satisfied for prevData then return
+          // if filters are not defined then skip the check
           if (
             pData &&
-            (await validateCondition(
-              testFilters || (await hook.getFilters()),
-              pData,
-            ))
+            filters.length &&
+            (await validateCondition(filters, pData))
           ) {
             continue;
           }
@@ -332,12 +333,11 @@ export async function invokeWebhook(
         newData = filteredData;
       } else {
         // if condition is satisfied for prevData then return
+        // if filters are not defined then skip the check
         if (
           prevData &&
-          (await validateCondition(
-            testFilters || (await hook.getFilters()),
-            prevData,
-          ))
+          filters.length &&
+          (await validateCondition(filters, prevData))
         ) {
           return;
         }