Browse Source

feat(nocodb): remove `>`, `<`, `>=`, `<=`, `is empty`, `is not empty`, `is equal`, `is not equal` for attachment columns

pull/5106/head
Wing-Kam Wong 2 years ago
parent
commit
21630df516
  1. 12
      packages/nocodb/src/lib/version-upgrader/ncFilterUpgrader_0104003.ts

12
packages/nocodb/src/lib/version-upgrader/ncFilterUpgrader_0104003.ts

@ -12,6 +12,7 @@ import { UITypes } from 'nocodb-sdk';
// - remove `like`, `null`, and `empty` for numeric-based / singleSelect columns - migrate to `blank` from `null` and `empty` // - remove `like`, `null`, and `empty` for numeric-based / singleSelect columns - migrate to `blank` from `null` and `empty`
// - remove `is null`, `is not null` for checkbox columns - migrate `equal` and `not equal` to `checked` and `not checked` // - remove `is null`, `is not null` for checkbox columns - migrate `equal` and `not equal` to `checked` and `not checked`
// - remove `like`, `null`, `equal` and `empty` for multiSelect columns // - remove `like`, `null`, `equal` and `empty` for multiSelect columns
// - remove `>`, `<`, `>=`, `<=`, `is empty`, `is not empty`, `is equal`, `is not equal` for attachment columns
export default async function ({ ncMeta }: NcUpgraderCtx) { export default async function ({ ncMeta }: NcUpgraderCtx) {
const filters = await ncMeta.metaList2(null, null, MetaTable.FILTER_EXP); const filters = await ncMeta.metaList2(null, null, MetaTable.FILTER_EXP);
@ -81,6 +82,17 @@ export default async function ({ ncMeta }: NcUpgraderCtx) {
actions.push(await Filter.delete(filter, ncMeta)); actions.push(await Filter.delete(filter, ncMeta));
// TODO: migrate to blank / not blank // TODO: migrate to blank / not blank
} }
} else if (col.uidt === UITypes.Attachment) {
// remove `>`, `<`, `>=`, `<=`
// remove `is empty`, `is not empty`
// remove `is equal`, `is not equal`
if (
['gt', 'lt', 'gte', 'lte', 'empty', 'notempty', 'eq', 'neq'].includes(
filter.comparison_op
)
) {
actions.push(await Filter.delete(filter, ncMeta));
}
} }
} }
await Promise.all(actions); await Promise.all(actions);

Loading…
Cancel
Save