From 21073b32cc88e3322d1dab352d5f03497fbbbaf0 Mon Sep 17 00:00:00 2001 From: mertmit Date: Sat, 4 May 2024 06:33:58 +0000 Subject: [PATCH] fix: avoid logging known db errors --- .../src/filters/global-exception/global-exception.filter.ts | 5 +++-- packages/nocodb/src/helpers/catchError.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/nocodb/src/filters/global-exception/global-exception.filter.ts b/packages/nocodb/src/filters/global-exception/global-exception.filter.ts index 9560a1db62..9f50b884a2 100644 --- a/packages/nocodb/src/filters/global-exception/global-exception.filter.ts +++ b/packages/nocodb/src/filters/global-exception/global-exception.filter.ts @@ -39,10 +39,13 @@ export class GlobalExceptionFilter implements ExceptionFilter { exception = new NcBaseErrorv2(NcErrorType.BAD_JSON); } + const dbError = extractDBError(exception); + // skip unnecessary error logging if ( process.env.NC_ENABLE_ALL_API_ERROR_LOGGING === 'true' || !( + dbError || exception instanceof BadRequest || exception instanceof AjvError || exception instanceof Unauthorized || @@ -97,8 +100,6 @@ export class GlobalExceptionFilter implements ExceptionFilter { return response.status(404).json({ msg: exception.message }); } - const dbError = extractDBError(exception); - if (dbError) { return response.status(400).json(dbError); } diff --git a/packages/nocodb/src/helpers/catchError.ts b/packages/nocodb/src/helpers/catchError.ts index a5a65682dd..93005a58fd 100644 --- a/packages/nocodb/src/helpers/catchError.ts +++ b/packages/nocodb/src/helpers/catchError.ts @@ -3,7 +3,7 @@ import { Logger } from '@nestjs/common'; import type { ErrorObject } from 'ajv'; import { defaultLimitConfig } from '~/helpers/extractLimitAndOffset'; -const dbErrorLogger = new Logger('DBError'); +const dbErrorLogger = new Logger('MissingDBError'); export enum DBError { TABLE_EXIST = 'TABLE_EXIST',