From 20f229fca06be9e498fe6611da62a3cfe9d5f776 Mon Sep 17 00:00:00 2001 From: mertmit Date: Fri, 17 Nov 2023 10:33:55 +0000 Subject: [PATCH] chore: add planned todos --- packages/nocodb/src/plugins/backblaze/Backblaze.ts | 1 + packages/nocodb/src/plugins/gcs/Gcs.ts | 1 + packages/nocodb/src/plugins/linode/LinodeObjectStorage.ts | 1 + packages/nocodb/src/plugins/mino/Minio.ts | 1 + packages/nocodb/src/plugins/ovhCloud/OvhCloud.ts | 1 + packages/nocodb/src/plugins/scaleway/ScalewayObjectStorage.ts | 1 + packages/nocodb/src/plugins/spaces/Spaces.ts | 1 + packages/nocodb/src/plugins/upcloud/UpoCloud.ts | 1 + packages/nocodb/src/plugins/vultr/Vultr.ts | 1 + 9 files changed, 9 insertions(+) diff --git a/packages/nocodb/src/plugins/backblaze/Backblaze.ts b/packages/nocodb/src/plugins/backblaze/Backblaze.ts index ecc6803b40..351ace6964 100644 --- a/packages/nocodb/src/plugins/backblaze/Backblaze.ts +++ b/packages/nocodb/src/plugins/backblaze/Backblaze.ts @@ -54,6 +54,7 @@ export default class Backblaze implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/gcs/Gcs.ts b/packages/nocodb/src/plugins/gcs/Gcs.ts index 0bc7340138..c3033e5454 100644 --- a/packages/nocodb/src/plugins/gcs/Gcs.ts +++ b/packages/nocodb/src/plugins/gcs/Gcs.ts @@ -110,6 +110,7 @@ export default class Gcs implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/linode/LinodeObjectStorage.ts b/packages/nocodb/src/plugins/linode/LinodeObjectStorage.ts index eec1276cdb..b830a6c261 100644 --- a/packages/nocodb/src/plugins/linode/LinodeObjectStorage.ts +++ b/packages/nocodb/src/plugins/linode/LinodeObjectStorage.ts @@ -53,6 +53,7 @@ export default class LinodeObjectStorage implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/mino/Minio.ts b/packages/nocodb/src/plugins/mino/Minio.ts index 33d875ea82..ea2bdd58f0 100644 --- a/packages/nocodb/src/plugins/mino/Minio.ts +++ b/packages/nocodb/src/plugins/mino/Minio.ts @@ -100,6 +100,7 @@ export default class Minio implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/ovhCloud/OvhCloud.ts b/packages/nocodb/src/plugins/ovhCloud/OvhCloud.ts index 42281d01a4..e1114f4a34 100644 --- a/packages/nocodb/src/plugins/ovhCloud/OvhCloud.ts +++ b/packages/nocodb/src/plugins/ovhCloud/OvhCloud.ts @@ -53,6 +53,7 @@ export default class OvhCloud implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/scaleway/ScalewayObjectStorage.ts b/packages/nocodb/src/plugins/scaleway/ScalewayObjectStorage.ts index 31ea0de26a..8c6459fb07 100644 --- a/packages/nocodb/src/plugins/scaleway/ScalewayObjectStorage.ts +++ b/packages/nocodb/src/plugins/scaleway/ScalewayObjectStorage.ts @@ -103,6 +103,7 @@ export default class ScalewayObjectStorage implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/spaces/Spaces.ts b/packages/nocodb/src/plugins/spaces/Spaces.ts index 5cfbd9184b..e2f94c3835 100644 --- a/packages/nocodb/src/plugins/spaces/Spaces.ts +++ b/packages/nocodb/src/plugins/spaces/Spaces.ts @@ -53,6 +53,7 @@ export default class Spaces implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/upcloud/UpoCloud.ts b/packages/nocodb/src/plugins/upcloud/UpoCloud.ts index 8e522f058b..ff6a31b4fb 100644 --- a/packages/nocodb/src/plugins/upcloud/UpoCloud.ts +++ b/packages/nocodb/src/plugins/upcloud/UpoCloud.ts @@ -53,6 +53,7 @@ export default class UpoCloud implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => { diff --git a/packages/nocodb/src/plugins/vultr/Vultr.ts b/packages/nocodb/src/plugins/vultr/Vultr.ts index 0a4d29a463..0d3e79c946 100644 --- a/packages/nocodb/src/plugins/vultr/Vultr.ts +++ b/packages/nocodb/src/plugins/vultr/Vultr.ts @@ -53,6 +53,7 @@ export default class Vultr implements IStorageAdapterV2 { .get(url, { httpAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), httpsAgent: useAgent(url, { stopPortScanningByUrlRedirection: true }), + // TODO - use stream instead of buffer responseType: 'arraybuffer', }) .then((response) => {