fix(api): block table deletion if there is a relation exist

Signed-off-by: Pranav C <pranavxc@gmail.com>

packages/nocodb/src/lib/noco/meta/api/tableApis.ts

@@ -5,10 +5,12 @@ import { Tele } from 'nc-help';
 import {
   AuditOperationSubTypes,
   AuditOperationTypes,
+  isVirtualCol,
   ModelTypes,
   TableListType,
   TableReqType,
-  TableType
+  TableType,
+  UITypes
 } from 'nocodb-sdk';
 import ProjectMgrv2 from '../../../sqlMgr/v2/ProjectMgrv2';
 import Project from '../../../noco-models/Project';
@@ -23,6 +25,7 @@ import getTableNameAlias, { getColumnNameAlias } from '../helpers/getTableName';
 import Column from '../../../noco-models/Column';
 import NcConnectionMgrv2 from '../../common/NcConnectionMgrv2';
 import getColumnUiType from '../helpers/getColumnUiType';
+import LinkToAnotherRecordColumn from '../../../noco-models/LinkToAnotherRecordColumn';
 export async function tableGet(req: Request, res: Response<TableType>) {
   const table = await Model.getWithInfo({
     id: req.params.tableId
@@ -199,15 +202,35 @@ export async function tableUpdate(req: Request<any, any>, res) {
   res.json({ msg: 'success' });
 }
 
-export async function tableDelete(req: Request, res: Response, next) {
-  try {
+export async function tableDelete(req: Request, res: Response) {
   const table = await Model.getByIdOrName({ id: req.params.tableId });
   await table.getColumns();
 
+  const relationColumns = table.columns.filter(
+    c => c.uidt === UITypes.LinkToAnotherRecord
+  );
+
+  if (relationColumns?.length) {
+    const referredTables = await Promise.all(
+      relationColumns.map(async c =>
+        c
+          .getColOptions<LinkToAnotherRecordColumn>()
+          .then(opt => opt.getRelatedTable())
+          .then()
+      )
+    );
+    NcError.badRequest(
+      `Table can't be  deleted  since Table is being referred in following tables : ${referredTables.join(
+        ', '
+      )}. Delete LinkToAnotherRecord columns and try again.`
+    );
+  }
+
   const project = await Project.getWithInfo(table.project_id);
   const base = project.bases.find(b => b.id === table.base_id);
   const sqlMgr = await ProjectMgrv2.getSqlMgr(project);
   (table as any).tn = table.table_name;
+  table.columns = table.columns.filter(c => !isVirtualCol(c));
   table.columns.forEach(c => {
     (c as any).cn = c.column_name;
   });
@@ -233,10 +256,6 @@ export async function tableDelete(req: Request, res: Response, next) {
   Tele.emit('evt', { evt_type: 'table:deleted' });
 
   res.json(await table.delete());
-  } catch (e) {
-    console.log(e);
-    next(e);
-  }
 }
 
 const router = Router({ mergeParams: true });