From 1ec856ec0551d5f8568f13c120921495d51ef139 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Fri, 20 Oct 2023 15:58:52 +0530 Subject: [PATCH] refactor: sync Signed-off-by: Pranav C --- packages/nc-gui/components/general/WorkspaceIcon.vue | 1 + packages/nocodb-sdk/src/lib/enums.ts | 3 +-- packages/nocodb/src/controllers/utils.controller.ts | 1 - packages/nocodb/src/modules/jobs/jobs.controller.ts | 12 +++++------- tests/playwright/setup/index.ts | 2 +- 5 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/nc-gui/components/general/WorkspaceIcon.vue b/packages/nc-gui/components/general/WorkspaceIcon.vue index 1735cae134..e5d14087ce 100644 --- a/packages/nc-gui/components/general/WorkspaceIcon.vue +++ b/packages/nc-gui/components/general/WorkspaceIcon.vue @@ -10,6 +10,7 @@ const props = defineProps<{ const workspaceColor = computed(() => { const color = props.workspace ? props.workspace.meta?.color || stringToColor(props.workspace.id!) : undefined + return color || '#0A1433' }) diff --git a/packages/nocodb-sdk/src/lib/enums.ts b/packages/nocodb-sdk/src/lib/enums.ts index 7d90bfecef..6d01a92c97 100644 --- a/packages/nocodb-sdk/src/lib/enums.ts +++ b/packages/nocodb-sdk/src/lib/enums.ts @@ -157,9 +157,8 @@ export enum WorkspaceStatus { export enum WorkspacePlan { FREE = 'free', - STANDARD = 'standard', + TEAM = 'team', BUSINESS = 'business', - BUSINESS_PRO = 'business-pro', } export const RoleLabels = { diff --git a/packages/nocodb/src/controllers/utils.controller.ts b/packages/nocodb/src/controllers/utils.controller.ts index 7910849c7e..cd9ca6ccd1 100644 --- a/packages/nocodb/src/controllers/utils.controller.ts +++ b/packages/nocodb/src/controllers/utils.controller.ts @@ -61,7 +61,6 @@ export class UtilsController { @Get([ '/api/v1/db/meta/nocodb/info', '/api/v2/meta/nocodb/info', - // todo: remove this once we added the health api '/api/v1/meta/nocodb/info', ]) async appInfo(@Request() req) { diff --git a/packages/nocodb/src/modules/jobs/jobs.controller.ts b/packages/nocodb/src/modules/jobs/jobs.controller.ts index 1ae1ca9e8e..f5a2cdeb4c 100644 --- a/packages/nocodb/src/modules/jobs/jobs.controller.ts +++ b/packages/nocodb/src/modules/jobs/jobs.controller.ts @@ -123,7 +123,7 @@ export class JobsController implements OnModuleInit { this.closedJobs.push(jobId); setTimeout(() => { this.closedJobs = this.closedJobs.filter((j) => j !== jobId); - }, POLLING_INTERVAL * 1.5); + }, POLLING_INTERVAL * 2); } break; } @@ -184,10 +184,9 @@ export class JobsController implements OnModuleInit { response = { status: 'update', data, - _mid: this.localJobs[jobId]._mid, + _mid: ++this.localJobs[jobId]._mid, }; this.localJobs[jobId].messages.push(response); - this.localJobs[jobId]._mid += 1; // limit to 20 messages if (this.localJobs[jobId].messages.length > 20) { @@ -233,13 +232,13 @@ export class JobsController implements OnModuleInit { this.closedJobs.push(jobId); setTimeout(() => { this.closedJobs = this.closedJobs.filter((j) => j !== jobId); - }, POLLING_INTERVAL * 1.5); + }, POLLING_INTERVAL * 2); setTimeout(() => { delete this.jobRooms[jobId]; delete this.localJobs[jobId]; NocoCache.del(`${CacheScope.JOBS}:${jobId}:messages`); - }, POLLING_INTERVAL); + }, POLLING_INTERVAL * 2); } } @@ -253,11 +252,10 @@ export class JobsController implements OnModuleInit { response = { status: 'update', data, - _mid: this.localJobs[jobId]._mid, + _mid: ++this.localJobs[jobId]._mid, }; this.localJobs[jobId].messages.push(response); - this.localJobs[jobId]._mid += 1; // limit to 20 messages if (this.localJobs[jobId].messages.length > 20) { diff --git a/tests/playwright/setup/index.ts b/tests/playwright/setup/index.ts index f0982d0e6b..8ff99934d8 100644 --- a/tests/playwright/setup/index.ts +++ b/tests/playwright/setup/index.ts @@ -181,7 +181,7 @@ async function localInit({ try { let response: AxiosResponse; // Login as root user - if (isSuperUser) { + if (isSuperUser && !isEE()) { // required for configuring license key settings response = await axios.post('http://localhost:8080/api/v1/auth/user/signin', { email: `user@nocodb.com`,