Browse Source

fix(extensions): org chart: typing and linting

nc-org-chart-extension
amandesai01 2 days ago
parent
commit
1eae77f79e
  1. 1
      packages/nc-gui/components/cell/MultiSelect.vue
  2. 2
      packages/nc-gui/composables/useExtensions.ts
  3. 12
      packages/nc-gui/utils/dataUtils.ts

1
packages/nc-gui/components/cell/MultiSelect.vue

@ -280,7 +280,6 @@ async function addIfMissingAndSave() {
updatedColMeta,
)
column.value.colOptions = data.columns.find((c) => c.id === column.value.id).colOptions
activeOptCreateInProgress.value--

2
packages/nc-gui/composables/useExtensions.ts

@ -447,7 +447,7 @@ export const useExtensions = createSharedComposable(() => {
if (availableExtensions.value.length + disabledCount === extensionCount) {
// Sort extensions
availableExtensions.value.sort((a, b) => a.title.localeCompare(b.title))
availableExtensions.value.sort((a, b) => (a.order ?? Infinity) - (b.order ?? Infinity))
extensionsLoaded.value = true
}
} catch (error) {

12
packages/nc-gui/utils/dataUtils.ts

@ -141,16 +141,16 @@ export const rowDefaultData = (columns: ColumnType[] = []) => {
}
export const isRowEmpty = (record: Row, col: ColumnType): boolean => {
if (!record || !col || !col.title) return true;
if (!record || !col || !col.title) return true
return !isValidValue(record.row[col.title]);
};
return !isValidValue(record.row[col.title])
}
export const isRowRecordEmpty = (record: Record<string, any>, col: ColumnType): boolean => {
if (!record || !col || !col.title) return true;
if (!record || !col || !col.title) return true
return !isValidValue(record[col.title]);
};
return !isValidValue(record[col.title])
}
export function validateRowFilters(_filters: FilterType[], data: any, columns: ColumnType[], client: any) {
if (!_filters.length) {

Loading…
Cancel
Save