From 1bb3c8d9ed94b9120956638c01426ed87f2bbf8b Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 17 May 2024 09:35:50 +0000
Subject: [PATCH] fix: acl check

---
 .../dashboard/settings/DataSources.vue        |  4 +++-
 .../components/dashboard/settings/Modal.vue   | 23 ++++++++++++-------
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/settings/DataSources.vue b/packages/nc-gui/components/dashboard/settings/DataSources.vue
index ca3590b035..b9a2bfe9c2 100644
--- a/packages/nc-gui/components/dashboard/settings/DataSources.vue
+++ b/packages/nc-gui/components/dashboard/settings/DataSources.vue
@@ -25,6 +25,8 @@ const { isDataSourceLimitReached } = storeToRefs(basesStore)
 const baseStore = useBase()
 const { base } = storeToRefs(baseStore)
 
+const { isUIAllowed } = useRoles()
+
 const { projectPageTab } = storeToRefs(useConfigStore())
 
 const { refreshCommandPalette } = useCommandPalette()
@@ -270,7 +272,7 @@ const openedTab = ref('erd')
       </a-breadcrumb>
 
       <NcButton
-        v-if="!isDataSourceLimitReached && !activeSource"
+        v-if="!isDataSourceLimitReached && !activeSource && isUIAllowed('sourceCreate')"
         size="large"
         class="z-10 !px-2"
         type="primary"
diff --git a/packages/nc-gui/components/dashboard/settings/Modal.vue b/packages/nc-gui/components/dashboard/settings/Modal.vue
index e5badfde59..710a09a736 100644
--- a/packages/nc-gui/components/dashboard/settings/Modal.vue
+++ b/packages/nc-gui/components/dashboard/settings/Modal.vue
@@ -40,6 +40,8 @@ const vDataState = useVModel(props, 'dataSourcesState', emits)
 
 const baseId = toRef(props, 'baseId')
 
+const { isUIAllowed } = useRoles()
+
 provide(ProjectIdInj, baseId)
 
 const { $e } = useNuxtApp()
@@ -180,15 +182,20 @@ watch(
       <!-- Side tabs -->
       <a-layout-sider>
         <a-menu v-model:selected-keys="selectedTabKeys" class="tabs-menu h-full" :open-keys="[]">
-          <a-menu-item v-for="(tab, key) of tabsInfo" :key="key" class="active:(!ring-0) hover:(!bg-primary !bg-opacity-25)">
-            <div class="flex items-center space-x-2" @click="tab.onClick">
-              <component :is="tab.icon" />
-
-              <div class="select-none">
-                {{ tab.title }}
+          <template v-for="(tab, key) of tabsInfo" :key="key">
+            <a-menu-item
+              v-if="key !== 'dataSources' || isUIAllowed('sourceCreate')"
+              class="active:(!ring-0) hover:(!bg-primary !bg-opacity-25)"
+            >
+              <div class="flex items-center space-x-2" @click="tab.onClick">
+                <component :is="tab.icon" />
+
+                <div class="select-none">
+                  {{ tab.title }}
+                </div>
               </div>
-            </div>
-          </a-menu-item>
+            </a-menu-item>
+          </template>
         </a-menu>
       </a-layout-sider>