From 1b9f1bafcd4ed6dffcee318933282cf49b3b2bbc Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 9 Aug 2021 20:09:01 +0530
Subject: [PATCH] feat: Add MID/SUBSTR function support

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../components/editColumn/formulaOptions.vue     | 16 +++++++++-------
 .../dataMapper/lib/sql/functionMappings/mssql.ts |  1 +
 .../dataMapper/lib/sql/functionMappings/mysql.ts |  3 ++-
 .../dataMapper/lib/sql/functionMappings/pg.ts    |  1 +
 .../lib/sql/functionMappings/sqlite.ts           |  3 ++-
 5 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/packages/nc-gui/components/project/spreadsheet/components/editColumn/formulaOptions.vue b/packages/nc-gui/components/project/spreadsheet/components/editColumn/formulaOptions.vue
index bc6858bae7..9bb5b2eccc 100644
--- a/packages/nc-gui/components/project/spreadsheet/components/editColumn/formulaOptions.vue
+++ b/packages/nc-gui/components/project/spreadsheet/components/editColumn/formulaOptions.vue
@@ -61,7 +61,7 @@
 <script>
 
 import NcAutocompleteTree from '@/helpers/NcAutocompleteTree'
-import { getWordUntilCaret, insertAtCursor } from '@/helpers'
+import {getWordUntilCaret, insertAtCursor} from '@/helpers'
 import debounce from 'debounce'
 import jsep from 'jsep'
 
@@ -87,7 +87,9 @@ export default {
       'SEARCH',
       'INT',
       'RIGHT',
-      'LEFT'
+      'LEFT',
+      'SUBSTR',
+      'MID'
     ],
     availableBinOps: ['+', '-', '*', '/'],
     autocomplete: false,
@@ -99,9 +101,9 @@ export default {
   computed: {
     suggestionsList() {
       return [
-        ...this.availableFunctions.map(fn => ({ text: fn, type: 'function' })),
-        ...this.meta.columns.map(c => ({ text: c._cn, type: 'column', c })),
-        ...this.availableBinOps.map(op => ({ text: op, type: 'op' }))
+        ...this.availableFunctions.map(fn => ({text: fn, type: 'function'})),
+        ...this.meta.columns.map(c => ({text: c._cn, type: 'column', c})),
+        ...this.availableBinOps.map(op => ({text: op, type: 'op'}))
       ]
     },
     acTree() {
@@ -113,7 +115,7 @@ export default {
     }
   },
   created() {
-    this.formula = this.value ? { ...this.value } : {}
+    this.formula = this.value ? {...this.value} : {}
   },
   methods: {
     async save() {
@@ -215,7 +217,7 @@ export default {
         this.$set(this.formula, 'value', insertAtCursor(this.$refs.input.$el.querySelector('input'), text, len))
       }
     },
-    _handleInputDeb: debounce(async function(self) {
+    _handleInputDeb: debounce(async function (self) {
       await self.handleInput()
     }, 250),
     handleInputDeb() {
diff --git a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mssql.ts b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mssql.ts
index 7922895fcd..1eeb433de5 100644
--- a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mssql.ts
+++ b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mssql.ts
@@ -49,6 +49,7 @@ const mssql = {
   INT: (args: MapFnArgs) => {
     return args.knex.raw(`CASE WHEN ISNUMERIC(${args.fn(args.pt.arguments[0]).toQuery()}) = 1 THEN FLOOR(${args.fn(args.pt.arguments[0]).toQuery()}) ELSE 0 END${args.colAlias}`)
   },
+  MID:'SUBSTR'
 }
 
 export default mssql;
diff --git a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mysql.ts b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mysql.ts
index 9c7f02f201..05055924e6 100644
--- a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mysql.ts
+++ b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/mysql.ts
@@ -19,7 +19,8 @@ const mysql2 = {
   },
   RIGHT:(args: MapFnArgs)=> {
     return args.knex.raw(`SUBSTR(${args.fn(args.pt.arguments[0])},-${args.fn(args.pt.arguments[1])})${args.colAlias}`)
-  }
+  },
+  MID:'SUBSTR'
 }
 
 
diff --git a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/pg.ts b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/pg.ts
index 04b984bf71..250f3788f0 100644
--- a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/pg.ts
+++ b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/pg.ts
@@ -15,6 +15,7 @@ const pg = {
     // todo: correction
     return args.knex.raw(`REGEXP_REPLACE(COALESCE(${args.fn(args.pt.arguments[0])}::character varying, '0'), '[^0-9]+|\\.[0-9]+' ,'')${args.colAlias}`)
   },
+  MID: 'SUBSTR'
 }
 
 
diff --git a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/sqlite.ts b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/sqlite.ts
index 1531017bcf..0986b31541 100644
--- a/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/sqlite.ts
+++ b/packages/nocodb/src/lib/dataMapper/lib/sql/functionMappings/sqlite.ts
@@ -31,7 +31,8 @@ const sqlite3 = {
   },
   RIGHT:(args: MapFnArgs)=> {
     return args.knex.raw(`SUBSTR(${args.fn(args.pt.arguments[0])},-${args.fn(args.pt.arguments[1])})${args.colAlias}`)
-  }
+  },
+  MID:'SUBSTR'
 }