From 1a7f4d732c7ec5f35ba3b3356fd084d3f85bc4e0 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Wed, 3 Aug 2022 16:17:54 +0800
Subject: [PATCH] refactor(gui-v2): remove unnecessary ref & use for of

---
 .../components/smartsheet-column/RatingOptions.vue          | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/nc-gui-v2/components/smartsheet-column/RatingOptions.vue b/packages/nc-gui-v2/components/smartsheet-column/RatingOptions.vue
index 5c8a65f2eb..483fbd8962 100644
--- a/packages/nc-gui-v2/components/smartsheet-column/RatingOptions.vue
+++ b/packages/nc-gui-v2/components/smartsheet-column/RatingOptions.vue
@@ -5,7 +5,7 @@ import { getMdiIcon, enumColor } from '@/utils'
 const { formState, validateInfos, setAdditionalValidations, sqlUi, onDataTypeChange, onAlter } = useColumnCreateStoreOrThrow()
 
 // cater existing v1 cases
-const iconList = ref([
+const iconList = [
   {
     full: 'mdi-star',
     empty: 'mdi-star-outline',
@@ -26,7 +26,7 @@ const iconList = ref([
     full: 'mdi-flag',
     empty: 'mdi-flag-outline',
   },
-])
+]
 
 const rowSize = ref(10)
 
@@ -48,7 +48,7 @@ function compare(colorA: any, colorB: any) {
       <a-form-item label="Icon">
         <a-select v-model:value="formState.meta.icon" size="small" class="w-52">
           <!-- TODO: handle value -->
-          <a-select-option v-for="(icon, i) in iconList ?? []" :key="i" :value="icon">
+          <a-select-option v-for="(icon, i) of iconList" :key="i" :value="icon">
             <component
               :is="getMdiIcon(icon.full)"
               :style="{