From 1a29bd016640ff12f4ddae932cf18b6dac969ad3 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Fri, 21 Oct 2022 15:56:40 +0800
Subject: [PATCH] refactor(nc-gui): rename variables & props

---
 packages/nc-gui/components/dlg/QuickImport.vue       | 12 ++++++------
 .../components/smartsheet/toolbar/MoreActions.vue    |  2 +-
 .../components/smartsheet/toolbar/ViewActions.vue    |  2 +-
 packages/nc-gui/components/template/Editor.vue       | 12 ++++++------
 packages/nc-gui/utils/parsers/CSVTemplateAdapter.ts  |  2 +-
 .../nc-gui/utils/parsers/ExcelTemplateAdapter.ts     |  2 +-
 packages/nc-gui/utils/parsers/JSONTemplateAdapter.ts |  2 +-
 7 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/packages/nc-gui/components/dlg/QuickImport.vue b/packages/nc-gui/components/dlg/QuickImport.vue
index 2b0b869c4e..f18ed5df6a 100644
--- a/packages/nc-gui/components/dlg/QuickImport.vue
+++ b/packages/nc-gui/components/dlg/QuickImport.vue
@@ -27,10 +27,10 @@ import type { importFileList, streamImportFileList } from '~/lib'
 interface Props {
   modelValue: boolean
   importType: 'csv' | 'json' | 'excel'
-  importOnly?: boolean
+  importDataOnly?: boolean
 }
 
-const { importType, importOnly = false, ...rest } = defineProps<Props>()
+const { importType, importDataOnly = false, ...rest } = defineProps<Props>()
 
 const emit = defineEmits(['update:modelValue'])
 
@@ -69,7 +69,7 @@ const importState = reactive({
     normalizeNested: true,
     autoSelectFieldTypes: true,
     firstRowAsHeaders: true,
-    importData: true,
+    shouldImportData: true,
   },
 })
 
@@ -199,7 +199,7 @@ async function parseAndExtractData(val: UploadFile[] | ArrayBuffer | string) {
 
     templateGenerator.parse(() => {
       templateData.value = templateGenerator!.getTemplate()
-      if (importOnly) importColumns.value = templateGenerator!.getColumns()
+      if (importDataOnly) importColumns.value = templateGenerator!.getColumns()
       importData.value = templateGenerator!.getData()
       templateEditorModal.value = true
       isParsingData.value = false
@@ -342,7 +342,7 @@ const beforeUpload = (file: UploadFile) => {
             :project-template="templateData"
             :import-data="importData"
             :import-columns="importColumns"
-            :import-only="importOnly"
+            :import-data-only="importDataOnly"
             :quick-import-type="importType"
             :max-rows-to-parse="importState.parserConfig.maxRowsToParse"
             class="nc-quick-import-template-editor"
@@ -448,7 +448,7 @@ const beforeUpload = (file: UploadFile) => {
 
             <!-- Import Data -->
             <a-form-item class="!my-2">
-              <a-checkbox v-model:checked="importState.parserConfig.importData">{{ $t('labels.importData') }}</a-checkbox>
+              <a-checkbox v-model:checked="importState.parserConfig.shouldImportData">{{ $t('labels.importData') }}</a-checkbox>
             </a-form-item>
           </div>
         </div>
diff --git a/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue b/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
index 6ef6335d71..8a6e9eb7c0 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
@@ -166,7 +166,7 @@ const exportFile = async (exportType: ExportTypes) => {
       </template>
     </a-dropdown>
 
-    <LazyDlgQuickImport v-if="quickImportDialog" v-model="quickImportDialog" import-type="csv" :import-only="true" />
+    <LazyDlgQuickImport v-if="quickImportDialog" v-model="quickImportDialog" import-type="csv" :import-data-only="true" />
 
     <LazyWebhookDrawer v-if="showWebhookDrawer" v-model="showWebhookDrawer" />
 
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ViewActions.vue b/packages/nc-gui/components/smartsheet/toolbar/ViewActions.vue
index c926a5c3d7..daa2c857f3 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ViewActions.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ViewActions.vue
@@ -228,7 +228,7 @@ const { isSqlView } = useSmartsheetStoreOrThrow()
       </template>
     </a-dropdown>
 
-    <LazyDlgQuickImport v-if="quickImportDialog" v-model="quickImportDialog" import-type="csv" :import-only="true" />
+    <LazyDlgQuickImport v-if="quickImportDialog" v-model="quickImportDialog" import-type="csv" :import-data-only="true" />
 
     <LazyWebhookDrawer v-if="showWebhookDrawer" v-model="showWebhookDrawer" />
 
diff --git a/packages/nc-gui/components/template/Editor.vue b/packages/nc-gui/components/template/Editor.vue
index 3b5dafcb54..de802d00c2 100644
--- a/packages/nc-gui/components/template/Editor.vue
+++ b/packages/nc-gui/components/template/Editor.vue
@@ -28,7 +28,7 @@ import {
 } from '#imports'
 import { TabType } from '~/lib'
 
-const { quickImportType, projectTemplate, importData, importColumns, importOnly, maxRowsToParse } = defineProps<Props>()
+const { quickImportType, projectTemplate, importData, importColumns, importDataOnly, maxRowsToParse } = defineProps<Props>()
 
 const emit = defineEmits(['import'])
 
@@ -41,7 +41,7 @@ interface Props {
   projectTemplate: Record<string, any>
   importData: Record<string, any>
   importColumns: any[]
-  importOnly: boolean
+  importDataOnly: boolean
   maxRowsToParse: number
 }
 
@@ -123,7 +123,7 @@ const validators = computed(() =>
 const { validate, validateInfos } = useForm(data, validators)
 
 const isValid = computed(() => {
-  if (importOnly) {
+  if (importDataOnly) {
     for (const record of srcDestMapping.value) {
       if (!fieldsValidation(record)) {
         return false
@@ -362,7 +362,7 @@ function fieldsValidation(record: Record<string, any>) {
 }
 
 async function importTemplate() {
-  if (importOnly) {
+  if (importDataOnly) {
     // validate required columns
     if (!missingRequiredColumnsValidation()) return
 
@@ -555,7 +555,7 @@ defineExpose({
 })
 
 onMounted(() => {
-  if (importOnly) {
+  if (importDataOnly) {
     mapDefaultColumns()
   }
 })
@@ -579,7 +579,7 @@ function isSelectDisabled(uidt: string, disableSelect = false) {
 
 <template>
   <a-spin :spinning="isImporting" :tip="importingTip" size="large">
-    <a-card v-if="importOnly">
+    <a-card v-if="importDataOnly">
       <a-form :model="data" name="import-only">
         <p v-if="data.tables && quickImportType === 'excel'" class="text-center">
           {{ data.tables.length }} sheet{{ data.tables.length > 1 ? 's' : '' }}
diff --git a/packages/nc-gui/utils/parsers/CSVTemplateAdapter.ts b/packages/nc-gui/utils/parsers/CSVTemplateAdapter.ts
index 70e85eab80..68877002d2 100644
--- a/packages/nc-gui/utils/parsers/CSVTemplateAdapter.ts
+++ b/packages/nc-gui/utils/parsers/CSVTemplateAdapter.ts
@@ -243,7 +243,7 @@ export default class CSVTemplateAdapter {
           that.updateTemplate(tableIdx)
 
           // parse table data
-          if (that.config.importData) {
+          if (that.config.shouldImportData) {
             steppers = 0
             parse(file.originFileObj as File, {
               worker: true,
diff --git a/packages/nc-gui/utils/parsers/ExcelTemplateAdapter.ts b/packages/nc-gui/utils/parsers/ExcelTemplateAdapter.ts
index ac3f2f17a3..8c47c58e03 100644
--- a/packages/nc-gui/utils/parsers/ExcelTemplateAdapter.ts
+++ b/packages/nc-gui/utils/parsers/ExcelTemplateAdapter.ts
@@ -205,7 +205,7 @@ export default class ExcelTemplateAdapter extends TemplateGenerator {
             this.project.tables.push(table)
 
             this.data[tn] = []
-            if (this.config.importData) {
+            if (this.config.shouldImportData) {
               let rowIndex = 0
               for (const row of rows.slice(1)) {
                 const rowData: Record<string, any> = {}
diff --git a/packages/nc-gui/utils/parsers/JSONTemplateAdapter.ts b/packages/nc-gui/utils/parsers/JSONTemplateAdapter.ts
index a3ea20a1e0..6a228a7488 100644
--- a/packages/nc-gui/utils/parsers/JSONTemplateAdapter.ts
+++ b/packages/nc-gui/utils/parsers/JSONTemplateAdapter.ts
@@ -64,7 +64,7 @@ export default class JSONTemplateAdapter extends TemplateGenerator {
       table.columns.push(...columns)
     }
 
-    if (this.config.importData) {
+    if (this.config.shouldImportData) {
       this._parseTableData(table)
     }