Merge pull request #2438 from nocodb/fix/wh-trigger

fix: webhook triggers

packages/nc-gui/components/project/spreadsheet/components/EditableCell.vue

@@ -42,6 +42,7 @@
       :is-form="isForm"
       :column="column"
       :is-locked="isLocked"
+      v-on="parentListeners"
     />
 
     <boolean-cell
@@ -74,6 +75,7 @@
       v-else-if="isTime"
       v-model="localState"
       v-on="parentListeners"
+      @save="$emit('save')"
     />
 
     <date-time-picker-cell
@@ -95,7 +97,6 @@
       :is-form="isForm"
       :column="column"
       v-on="parentListeners"
-      @input="$emit('save')"
     />
 
     <json-editable-cell
@@ -111,7 +112,6 @@
       v-model="localState"
       :column="column"
       v-on="parentListeners"
-      @input="$emit('save')"
     />
     <set-list-cell
       v-else-if="isSet"
@@ -210,10 +210,10 @@ export default {
         if (val !== this.value) {
           this.changed = true
           this.$emit('input', val)
-          if (this.isAttachment || this.isBoolean || this.isRating || this.isTime || this.isDateTime || this.isDate || this.isDuration) {
+          if (this.isAutoSaved) {
-            this.syncData()
-          } else if (!this.isCurrency && !this.isEnum && !this.isSet) {
             this.syncDataDebounce(this)
+          } else if (!this.isManualSaved) {
+            this.saveData()
           }
         }
       }
@@ -241,7 +241,7 @@ export default {
     // this.$refs.input.focus();
   },
   beforeDestroy() {
-    if (this.changed && !(this.isAttachment || this.isBoolean || this.isRating || this.isTime || this.isDateTime || this.isDuration)) {
+    if (this.changed && this.isAutoSaved) {
       this.changed = false
       this.$emit('change')
     }
@@ -253,6 +253,12 @@ export default {
         this.changed = false
         this.$emit('update')
       }
+    },
+    saveData() {
+      if (this.changed && !this.destroyed) {
+        this.changed = false
+        this.$emit('save')
+      }
     }
   }
 }

packages/nc-gui/components/project/spreadsheet/components/editableCell/DurationCell.vue

@@ -7,6 +7,7 @@
       @blur="onBlur"
       @keypress="checkDurationFormat($event)"
       @keydown.enter="isEdited && $emit('input', durationInMS)"
+      v-on="parentListeners"
     >
     <div v-if="showWarningMessage == true" class="duration-warning">
       <!-- TODO: i18n -->
@@ -51,6 +52,18 @@ export default {
     },
     durationType() {
       return this.column?.meta?.duration || 0
+    },
+    parentListeners() {
+      const $listeners = {}
+
+      if (this.$listeners.blur) {
+        $listeners.blur = this.$listeners.blur
+      }
+      if (this.$listeners.focus) {
+        $listeners.focus = this.$listeners.focus
+      }
+
+      return $listeners
     }
   },
   mounted() {

packages/nc-gui/components/project/spreadsheet/components/editableCell/TimePickerCell.vue

@@ -5,7 +5,7 @@
     </template>
     <div class="d-flex flex-column justify-center" @click.stop>
       <v-time-picker v-model="localState" v-on="parentListeners" />
-      <v-btn small color="primary" @click="$emit('update')">
+      <v-btn small color="primary" @click="$emit('save')">
         <!-- Save -->
         {{ $t('general.save') }}
       </v-btn>
@@ -15,7 +15,6 @@
 
 <script>
 import dayjs from 'dayjs'
-import { MysqlUi } from 'nocodb-sdk'
 
 export default {
   name: 'TimePickerCell',

packages/nc-gui/components/project/spreadsheet/mixins/cell.js

@@ -70,6 +70,30 @@ export default {
     },
     isDuration() {
       return this.uiDatatype === UITypes.Duration
+    },
+    isAutoSaved() {
+      return [
+        UITypes.SingleLineText,
+        UITypes.LongText,
+        UITypes.PhoneNumber,
+        UITypes.Email,
+        UITypes.URL,
+        UITypes.Number,
+        UITypes.Decimal,
+        UITypes.Percent,
+        UITypes.Count,
+        UITypes.AutoNumber,
+        UITypes.SpecificDBType,
+        UITypes.Geometry
+      ].includes(this.uiDatatype)
+    },
+    isManualSaved() {
+      return [
+        UITypes.Currency,
+        UITypes.Year,
+        UITypes.Time,
+        UITypes.Duration
+      ].includes(this.uiDatatype)
     }
   }
 }