Merge pull request #7573 from nocodb/nc-fix/shared-base-breadcrumb

Nc - fix: shared base breadcrumb links and view options access issue

packages/nc-gui/components/dashboard/TreeView/ViewsNode.vue

@@ -256,7 +256,7 @@ watch(isDropdownOpen, async () => {
       </NcTooltip>
       <div class="flex-1" />
 
-      <template v-if="!isEditing && !isLocked && isUIAllowed('viewCreateOrEdit')">
+      <template v-if="!isEditing && !isLocked">
         <NcDropdown v-model:visible="isDropdownOpen" overlay-class-name="!rounded-lg">
           <NcButton
             v-e="['c:view:option']"

packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue

@@ -161,8 +161,9 @@ const onDelete = async () => {
         </NcButton>
       </div>
     </NcTooltip>
+
+    <template v-if="!view?.is_default && isUIAllowed('viewCreateOrEdit')">
       <NcDivider />
-    <template v-if="!view?.is_default">
       <NcMenuItem v-if="lockType !== LockType.Locked" @click="onRenameMenuClick">
         <GeneralIcon icon="rename" />
         {{ $t('activity.renameView') }}
@@ -283,7 +284,7 @@ const onDelete = async () => {
       </NcSubMenu>
     </template>
 
-    <template v-if="!view.is_default">
+    <template v-if="!view.is_default && isUIAllowed('viewCreateOrEdit')">
       <NcDivider />
       <NcTooltip v-if="lockType === LockType.Locked">
         <template #title> {{ $t('msg.info.disabledAsViewLocked') }} </template>

packages/nc-gui/components/smartsheet/toolbar/ViewInfo.vue

@@ -17,6 +17,7 @@ const openedBaseUrl = computed(() => {
   return `${window.location.origin}/#${baseUrl({
     id: base.value.id!,
     type: 'database',
+    isSharedBase: isSharedBase.value,
   })}`
 })
 </script>
@@ -112,7 +113,7 @@ const openedBaseUrl = computed(() => {
             <NuxtLink
               v-else
               class="!text-inherit !underline-transparent !hover:(text-black underline-gray-600)"
-              :to="tableUrl({ table: activeTable, completeUrl: true })"
+              :to="tableUrl({ table: activeTable, completeUrl: true, isSharedBase })"
             >
               {{ activeTable?.title }}
             </NuxtLink>

packages/nc-gui/store/tables.ts

@@ -214,17 +214,26 @@ export const useTablesStore = defineStore('tablesStore', () => {
     }
   }
 
-  const tableUrl = ({ table, completeUrl }: { table: TableType; completeUrl: boolean }) => {
-    const base = basesStore.bases.get(table.base_id!)
+  const tableUrl = ({ table, completeUrl, isSharedBase }: { table: TableType; completeUrl: boolean; isSharedBase?: boolean }) => {
+    let base
+    if (!isSharedBase) {
+      base = basesStore.bases.get(table.base_id!)
       if (!base) return
+    }
 
     const nuxtPageName = 'index-typeOrId-baseId-index-index-viewId-viewTitle'
 
     const url = router.resolve({
       name: nuxtPageName,
-      params: {
+      params: isSharedBase
+        ? {
+            typeOrId: route.value.params.typeOrId,
+            baseId: route.value.params.baseId,
+            viewId: route.value.params.viewId,
+          }
+        : {
             typeOrId: workspaceStore.activeWorkspaceId,
-        baseId: base.id,
+            baseId: base?.id,
             viewId: table.id,
           },
     })