From 120bdd7c6a4324fbdd9cbcbe58d3776fa6859a8c Mon Sep 17 00:00:00 2001
From: Raju Udava <86527202+dstala@users.noreply.github.com>
Date: Thu, 1 Sep 2022 22:24:36 +0530
Subject: [PATCH] refactor: i18n roles menu

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
---
 .../components/general/PreviewAs.vue          | 26 ++++++++++++-------
 packages/nc-gui-v2/composables/useViewData.ts |  2 +-
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/packages/nc-gui-v2/components/general/PreviewAs.vue b/packages/nc-gui-v2/components/general/PreviewAs.vue
index 2470447fd2..471b45168c 100644
--- a/packages/nc-gui-v2/components/general/PreviewAs.vue
+++ b/packages/nc-gui-v2/components/general/PreviewAs.vue
@@ -1,4 +1,5 @@
 <script lang="ts" setup>
+import { useI18n } from 'vue-i18n'
 import { onUnmounted, useEventListener, useGlobal, useState, watch } from '#imports'
 import MdiAccountStar from '~icons/mdi/account-star'
 import MdiAccountHardHat from '~icons/mdi/account-hard-hat'
@@ -13,7 +14,13 @@ const position = useState('preview-as-position', () => ({
   x: `${window.innerWidth / 2 - 250}px`,
 }))
 
-const roleList = [{ title: 'editor' }, { title: 'commenter' }, { title: 'viewer' }]
+const { t } = useI18n()
+
+const roleList = [
+  { value: 'editor', label: t('objects.roleType.editor') },
+  { value: 'commenter', label: t('objects.roleType.commenter') },
+  { value: 'viewer', label: t('objects.roleType.viewer') },
+]
 
 const { previewAs } = useGlobal()
 
@@ -62,28 +69,29 @@ watch(previewAs, () => window.location.reload())
       <span>{{ $t('activity.previewAs') }}</span>
 
       <a-radio-group v-model:value="previewAs" name="radioGroup">
-        <a-radio v-for="role of roleList" :key="role.title" class="capitalize !text-white" :value="role.title"
-          >{{ role.title }}
+        <a-radio v-for="role of roleList" :key="role.value" class="capitalize !text-white" :value="role.value"
+          >{{ role.label }}
         </a-radio>
       </a-radio-group>
 
       <div class="divider -ml-4" />
 
+      <!-- Close -->
       <div class="flex items-center gap-2 cursor-pointer" @click="previewAs = null">
         <MdiExitToApp />
-        Exit
+        {{ $t('general.close') }}
       </div>
     </div>
   </div>
 
   <template v-else>
-    <template v-for="role of roleList" :key="role.title">
-      <a-menu-item @click="previewAs = role.title">
+    <template v-for="role of roleList" :key="role.value">
+      <a-menu-item @click="previewAs = role.value">
         <div class="nc-project-menu-item group">
-          <component :is="roleIcon[role.title]" class="group-hover:text-accent" />
+          <component :is="roleIcon[role.value]" class="group-hover:text-accent" />
 
-          <span class="capitalize" :class="{ 'x-active--text': role.title === previewAs }">
-            {{ role.title }}
+          <span class="capitalize" :class="{ 'x-active--text': role.value === previewAs }">
+            {{ role.label }}
           </span>
         </div>
       </a-menu-item>
diff --git a/packages/nc-gui-v2/composables/useViewData.ts b/packages/nc-gui-v2/composables/useViewData.ts
index 09005a623d..42bc1ed74f 100644
--- a/packages/nc-gui-v2/composables/useViewData.ts
+++ b/packages/nc-gui-v2/composables/useViewData.ts
@@ -162,7 +162,7 @@ export function useViewData(
   async function loadData(params: Parameters<Api<any>['dbViewRow']['list']>[4] = {}) {
     if ((!project?.value?.id || !meta?.value?.id || !viewMeta?.value?.id) && !isPublic.value) return
     const response = !isPublic.value
-      ? await api.dbViewRow.list('noco', project.value.id!, meta?.value.id!, viewMeta!.value.id, {
+      ? await api.dbViewRow.list('noco', project.value.id!, meta!.value.id!, viewMeta!.value.id, {
           ...params,
           ...(isUIAllowed('sortSync') ? {} : { sortArrJson: JSON.stringify(sorts.value) }),
           ...(isUIAllowed('filterSync') ? {} : { filterArrJson: JSON.stringify(nestedFilters.value) }),