From 0fb4c4878df58c98f88fcc5b4aea1ae034dc7d93 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Wed, 7 Aug 2024 21:11:14 +0530
Subject: [PATCH] fix(nc-gui): source erd test fail issue

---
 .../nc-gui/components/dashboard/TreeView/ProjectNode.vue     | 2 +-
 packages/nocodb-sdk/src/lib/Api.ts                           | 2 ++
 .../playwright/pages/Dashboard/ProjectView/DataSourcePage.ts | 5 ++---
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
index fded4afba6..e57ebc09de 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
@@ -739,7 +739,7 @@ async function openAudit(source: SourceType) {
                     v-e="['c:source:toggle-expand']"
                     class="!mx-0 !px-0 nc-sidebar-source-node"
                     :class="[{ hidden: searchActive && !!filterQuery }]"
-                    expand-icon-position="left"
+                    expand-icon-position="right"
                     :bordered="false"
                     ghost
                   >
diff --git a/packages/nocodb-sdk/src/lib/Api.ts b/packages/nocodb-sdk/src/lib/Api.ts
index f70bf45966..7b36409531 100644
--- a/packages/nocodb-sdk/src/lib/Api.ts
+++ b/packages/nocodb-sdk/src/lib/Api.ts
@@ -10605,6 +10605,7 @@ export class Api<
   defaultLimit?: number,
   ncMin?: boolean,
   teleEnabled?: boolean,
+  errorReportingEnabled?: boolean,
   auditEnabled?: boolean,
   ncSiteUrl?: string,
   ee?: boolean,
@@ -10636,6 +10637,7 @@ export class Api<
           defaultLimit?: number;
           ncMin?: boolean;
           teleEnabled?: boolean;
+          errorReportingEnabled?: boolean;
           auditEnabled?: boolean;
           ncSiteUrl?: string;
           ee?: boolean;
diff --git a/tests/playwright/pages/Dashboard/ProjectView/DataSourcePage.ts b/tests/playwright/pages/Dashboard/ProjectView/DataSourcePage.ts
index 52f49be443..f11457fe76 100644
--- a/tests/playwright/pages/Dashboard/ProjectView/DataSourcePage.ts
+++ b/tests/playwright/pages/Dashboard/ProjectView/DataSourcePage.ts
@@ -71,10 +71,9 @@ export class DataSourcePage extends BasePage {
 
     await row.click();
 
-    await this.getDsDetailsModal().waitFor({ state: 'visible' });
+    // kludge: only in testing it's not rendering all tables
+    await this.getDsDetailsModal().getByTestId('nc-acl-tab').click();
     await this.getDsDetailsModal().getByTestId('nc-erd-tab').click();
-
-    // await row.getByTestId('nc-data-sources-view-erd').click();
   }
 
   async openAudit({ rowIndex }: { rowIndex: number }) {