From d5262c1e9c5941071b75c11ce6fc98117df2a58f Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Fri, 19 May 2023 15:36:28 +0530 Subject: [PATCH 1/2] fix(nocodb): revise filterId to string type --- packages/nocodb/src/services/filters.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nocodb/src/services/filters.service.ts b/packages/nocodb/src/services/filters.service.ts index 62a08f2294..5ea8e8ca00 100644 --- a/packages/nocodb/src/services/filters.service.ts +++ b/packages/nocodb/src/services/filters.service.ts @@ -51,7 +51,7 @@ export class FiltersService { return filter; } - async filterChildrenList(param: { filterId: any }) { + async filterChildrenList(param: { filterId: string }) { return Filter.parentFilterList({ parentId: param.filterId, }); From 088c12b352bca6309439938fd62a511e786fd838 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Fri, 19 May 2023 15:36:43 +0530 Subject: [PATCH 2/2] fix(nocodb): add missing Param filterParentId --- packages/nocodb/src/controllers/filters.controller.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nocodb/src/controllers/filters.controller.ts b/packages/nocodb/src/controllers/filters.controller.ts index 765d4d68bf..dc09b0c705 100644 --- a/packages/nocodb/src/controllers/filters.controller.ts +++ b/packages/nocodb/src/controllers/filters.controller.ts @@ -71,7 +71,7 @@ export class FiltersController { @Get('/api/v1/db/meta/filters/:filterParentId/children') @Acl('filterChildrenList') - async filterChildrenRead(filterParentId: string) { + async filterChildrenRead(@Param('filterParentId') filterParentId: string) { return new PagedResponseImpl( await this.filtersService.filterChildrenList({ filterId: filterParentId,