chore/Added Pr suggestions and removed isShareView page meta

packages/nc-gui-v2/components/cell/Checkbox.vue

@@ -1,6 +1,5 @@
 <script setup lang="ts">
-import { ColumnInj, IsFormInj, getMdiIcon, inject } from '#imports'
+import { ColumnInj, IsFormInj, ReadonlyInj, getMdiIcon, inject } from '#imports'
-import { ReadonlyInj } from '~/context'
 
 interface Props {
   modelValue?: boolean | undefined | number

packages/nc-gui-v2/composables/useViewColumns.ts

@@ -121,16 +121,17 @@ export function useViewColumns(view: Ref<ViewType> | undefined, meta: ComputedRe
     reloadData?.()
   }
 
-  const metaColumnById = computed<Record<string, ColumnType>>(
+  const metaColumnById = computed<Record<string, ColumnType>>(() => {
-    () =>
+    if (!meta.value?.columns) return {}
-      meta.value?.columns?.reduce(
+
-        (acc: ColumnType, curr: ColumnType) => ({
+    return meta.value?.columns?.reduce(
-          ...acc,
+      (acc: ColumnType, curr: ColumnType) => ({
-          [curr.id!]: curr,
+        ...acc,
-        }),
+        [curr.id!]: curr,
-        {},
+      }),
-      ) || {},
+      {} as any,
-  )
+    )
+  })
 
   const showSystemFields = computed({
     get() {

packages/nc-gui-v2/middleware/auth.global.ts

@@ -26,7 +26,7 @@ export default defineNuxtRouteMiddleware((to, from) => {
   /** if shred base allow without validating */
   if (to.params?.projectType === 'base') return
 
-  if (to.meta.isSharedView) return
+  if (to.meta.public) return
 
   /** if auth is required or unspecified (same as required) and user is not signed in, redirect to signin page */
   if ((to.meta.requiresAuth || typeof to.meta.requiresAuth === 'undefined') && !state.signedIn.value) {

packages/nc-gui-v2/pages/[projectType]/view/[viewId].vue

@@ -5,18 +5,17 @@ import {
   ReloadViewDataHookInj,
   createEventHook,
   definePageMeta,
+  extractSdkResponseErrorMsg,
   provide,
   ref,
   useRoute,
   useSharedView,
 } from '#imports'
-import { extractSdkResponseErrorMsg } from '~/utils'
 
 definePageMeta({
   public: true,
   requiresAuth: false,
   layout: 'shared-view',
-  isSharedView: true,
 })
 
 const route = useRoute()