From 0b184fc3ca5709d4e861da3dbf83621db73225f9 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Tue, 18 Jun 2024 19:06:18 +0000
Subject: [PATCH] feat: allow virtual column add/edit/remove - backend

---
 .../smartsheet/column/EditOrAdd.vue           | 10 +------
 .../column/UITypesOptionsWithSearch.vue       | 11 +-------
 packages/nocodb-sdk/src/lib/UITypes.ts        | 10 +++++++
 packages/nocodb-sdk/src/lib/index.ts          |  1 +
 .../nocodb/src/services/columns.service.ts    | 28 +++++++++++++++++++
 5 files changed, 41 insertions(+), 19 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue b/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
index afe9ebeb23..931f916fc8 100644
--- a/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
+++ b/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 import type { ColumnReqType, ColumnType } from 'nocodb-sdk'
-import { UITypes, UITypesName, isLinksOrLTAR, isSelfReferencingTableColumn, isSystemColumn, isVirtualCol } from 'nocodb-sdk'
+import { UITypes, UITypesName, isLinksOrLTAR, isSelfReferencingTableColumn, isSystemColumn, isVirtualCol, readonlyMetaAllowedTypes } from 'nocodb-sdk'
 import MdiPlusIcon from '~icons/mdi/plus-circle-outline'
 import MdiMinusIcon from '~icons/mdi/minus-circle-outline'
 import MdiIdentifierIcon from '~icons/mdi/identifier'
@@ -101,14 +101,6 @@ const onlyNameUpdateOnEditColumns = [
   UITypes.Barcode,
 ]
 
-const readonlyMetaAllowedTypes = [
-  UITypes.Lookup,
-  UITypes.Rollup,
-  UITypes.Formula,
-  UITypes.Barcode,
-  UITypes.QrCode,
-]
-
 // To close column type dropdown on escape and
 // close modal only when the type popup is close
 const isColumnTypeOpen = ref(false)
diff --git a/packages/nc-gui/components/smartsheet/column/UITypesOptionsWithSearch.vue b/packages/nc-gui/components/smartsheet/column/UITypesOptionsWithSearch.vue
index c586adb66a..6ac463f1a3 100644
--- a/packages/nc-gui/components/smartsheet/column/UITypesOptionsWithSearch.vue
+++ b/packages/nc-gui/components/smartsheet/column/UITypesOptionsWithSearch.vue
@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { UITypes, UITypesName } from 'nocodb-sdk'
+import { UITypes, UITypesName, readonlyMetaAllowedTypes } from 'nocodb-sdk'
 
 const props = defineProps<{
   options: typeof uiTypes
@@ -65,15 +65,6 @@ onMounted(() => {
   activeFieldIndex.value = options.value.findIndex((o) => o.name === UITypes.SingleLineText)
 })
 
-
-const readonlyMetaAllowedTypes = [
-  UITypes.Lookup,
-  UITypes.Rollup,
-  UITypes.Formula,
-  UITypes.Barcode,
-  UITypes.QrCode,
-]
-
 const isDisabledUIType = (type: UITypes) => {
   return isMetaReadOnly.value && !readonlyMetaAllowedTypes.includes(type)
 }
diff --git a/packages/nocodb-sdk/src/lib/UITypes.ts b/packages/nocodb-sdk/src/lib/UITypes.ts
index c2bc95cbaf..6dd66e20a4 100644
--- a/packages/nocodb-sdk/src/lib/UITypes.ts
+++ b/packages/nocodb-sdk/src/lib/UITypes.ts
@@ -254,3 +254,13 @@ export const isSelectTypeCol = (
   );
 };
 export default UITypes;
+
+
+export const readonlyMetaAllowedTypes = [
+  UITypes.Lookup,
+  UITypes.Rollup,
+  UITypes.Formula,
+  UITypes.Barcode,
+  UITypes.QrCode,
+]
+
diff --git a/packages/nocodb-sdk/src/lib/index.ts b/packages/nocodb-sdk/src/lib/index.ts
index 75a547a167..0f108d90f6 100644
--- a/packages/nocodb-sdk/src/lib/index.ts
+++ b/packages/nocodb-sdk/src/lib/index.ts
@@ -20,6 +20,7 @@ export {
   isHiddenCol,
   getEquivalentUIType,
   isSelectTypeCol,
+  readonlyMetaAllowedTypes,
 } from '~/lib/UITypes';
 export { default as CustomAPI, FileType } from '~/lib/CustomAPI';
 export { default as TemplateGenerator } from '~/lib/TemplateGenerator';
diff --git a/packages/nocodb/src/services/columns.service.ts b/packages/nocodb/src/services/columns.service.ts
index f47296dec1..fae07000b7 100644
--- a/packages/nocodb/src/services/columns.service.ts
+++ b/packages/nocodb/src/services/columns.service.ts
@@ -5,7 +5,9 @@ import {
   isCreatedOrLastModifiedTimeCol,
   isLinksOrLTAR,
   isVirtualCol,
+  readonlyMetaAllowedTypes,
   RelationTypes,
+  SourceRestriction,
   substituteColumnAliasWithIdInFormula,
   substituteColumnIdWithAliasInFormula,
   UITypes,
@@ -197,6 +199,16 @@ export class ColumnsService {
       Source.get(context, table.source_id),
     );
 
+    // check if source is readonly and column type is not allowed
+    if (
+      source?.meta?.[SourceRestriction.META_READONLY] &&
+      (!readonlyMetaAllowedTypes.includes(column.uidt) ||
+        (param.column.uidt &&
+          !readonlyMetaAllowedTypes.includes(param.column.uidt as UITypes)))
+    ) {
+      NcError.sourceMetaReadOnly(source.alias);
+    }
+
     const sqlClient = await reuseOrSave('sqlClient', reuse, async () =>
       NcConnectionMgrv2.getSqlClient(source),
     );
@@ -1482,6 +1494,14 @@ export class ColumnsService {
       Source.get(context, table.source_id),
     );
 
+    // check if source is readonly and column type is not allowed
+    if (
+      source?.meta?.[SourceRestriction.META_READONLY] &&
+      !readonlyMetaAllowedTypes.includes(param.column.uidt as UITypes)
+    ) {
+      NcError.sourceMetaReadOnly(source.alias);
+    }
+
     const base = await reuseOrSave('base', reuse, async () =>
       source.getProject(context),
     );
@@ -2042,6 +2062,14 @@ export class ColumnsService {
       Source.get(context, table.source_id, false, ncMeta),
     );
 
+    // check if source is readonly and column type is not allowed
+    if (
+      source?.meta?.[SourceRestriction.META_READONLY] &&
+      !readonlyMetaAllowedTypes.includes(column.uidt)
+    ) {
+      NcError.sourceMetaReadOnly(source.alias);
+    }
+
     const sqlMgr = await reuseOrSave('sqlMgr', reuse, async () =>
       ProjectMgrv2.getSqlMgr(context, { id: source.base_id }, ncMeta),
     );