From 095a6350385b59e3e16aff50bbb4c1bd169c23e5 Mon Sep 17 00:00:00 2001
From: Raju Udava <86527202+dstala@users.noreply.github.com>
Date: Tue, 20 Sep 2022 22:35:26 +0530
Subject: [PATCH] test: remove redundant login invocation

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
---
 .../virtual-cell/components/ListChildItems.vue  |  2 +-
 .../common/4g_table_view_expanded_form.js       | 17 +++++++++++------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue b/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
index f190784b47..939a4ccb9d 100644
--- a/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ListChildItems.vue
@@ -81,7 +81,7 @@ const expandedFormRow = ref()
 watch(
   () => props.cellValue,
   () => {
-    if (!isNew.value) loadChildrenList()
+    if (!isNew.value && vModel.value) loadChildrenList()
   },
 )
 </script>
diff --git a/scripts/cypress/integration/common/4g_table_view_expanded_form.js b/scripts/cypress/integration/common/4g_table_view_expanded_form.js
index ddf97541bb..e9bde2aa21 100644
--- a/scripts/cypress/integration/common/4g_table_view_expanded_form.js
+++ b/scripts/cypress/integration/common/4g_table_view_expanded_form.js
@@ -6,12 +6,18 @@ function capitalizeFirstLetter(string) {
   return string.charAt(0).toUpperCase() + string.slice(1);
 }
 
+// function verifyExpandFormHeader(title) {
+//   cy.getActiveDrawer(".nc-drawer-expanded-form")
+//     .should("exist")
+//     .find(".nc-expanded-form-header")
+//     .contains(title)
+//     .should("exist");
+// }
+
 function verifyExpandFormHeader(title) {
-  cy.getActiveDrawer(".nc-drawer-expanded-form")
-    .should("exist")
-    .find(".nc-expanded-form-header")
-    .contains(title)
-    .should("exist");
+  cy.get(
+    `.nc-drawer-expanded-form .nc-expanded-form-header :contains("${title}")`
+  ).should("exist");
 }
 
 export const genTest = (apiType, dbType) => {
@@ -19,7 +25,6 @@ export const genTest = (apiType, dbType) => {
 
   describe(`${apiType.toUpperCase()} api - Table views: Expanded form`, () => {
     before(() => {
-      loginPage.loginAndOpenProject(apiType, dbType);
       cy.restoreLocalStorage();
 
       // open a table to work on views