Browse Source

Merge pull request #4153 from mateonunez/fix/expand-locked-grid-view

fix(nc-gui): allow expand when is locked
pull/3420/head
Raju Udava 2 years ago committed by GitHub
parent
commit
08d73677dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/nc-gui/components/smartsheet/Grid.vue
  2. 3
      scripts/cypress/integration/common/4d_table_view_grid_locked.js

2
packages/nc-gui/components/smartsheet/Grid.vue

@ -566,7 +566,7 @@ watch(
<span class="flex-1" />
<div
v-if="(!readOnly || hasRole('commenter', true) || hasRole('viewer', true)) && !isLocked"
v-if="!readOnly || hasRole('commenter', true) || hasRole('viewer', true)"
class="nc-expand"
:class="{ 'nc-comment': row.rowMeta?.commentCount }"
>

3
scripts/cypress/integration/common/4d_table_view_grid_locked.js

@ -76,7 +76,8 @@ export const genTest = (apiType, dbType) => {
mainPage.getCell("Country", 1).dblclick();
mainPage.getCell("Country", 1).find("input").should(`${vString}exist`);
cy.get(".nc-row-expand").should(`${vString}exist`);
// the expand button should be always enabled
cy.get(".nc-row-expand").should("exist");
// check if add/ expand options available for 'has many' column type
// GUI-v2: TBD

Loading…
Cancel
Save