From 08d215e70f464c58014732e147c96cba9581c461 Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Tue, 19 Sep 2023 12:12:35 +0000
Subject: [PATCH] fix: share project permission

---
 packages/nc-gui/components/general/ShareProject.vue           | 2 +-
 packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue | 2 +-
 packages/nc-gui/components/smartsheet/toolbar/ShareView.vue   | 2 +-
 packages/nc-gui/composables/useRoles/index.ts                 | 4 ++--
 packages/nc-gui/lib/constants.ts                              | 3 ++-
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/general/ShareProject.vue b/packages/nc-gui/components/general/ShareProject.vue
index fadf05b97d..f5ad7daa14 100644
--- a/packages/nc-gui/components/general/ShareProject.vue
+++ b/packages/nc-gui/components/general/ShareProject.vue
@@ -36,7 +36,7 @@ useEventListener(document, 'keydown', async (e: KeyboardEvent) => {
 
 <template>
   <div
-    v-if="isUIAllowed('shareProject') && visibility !== 'hidden' && (activeTable || project)"
+    v-if="isUIAllowed('projectShare') && visibility !== 'hidden' && (activeTable || project)"
     class="flex flex-col justify-center h-full"
     data-testid="share-project-button"
     :data-sharetype="visibility"
diff --git a/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue b/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
index e9fa6581c2..02509301c7 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/MoreActions.vue
@@ -146,7 +146,7 @@ const exportFile = async (exportType: ExportTypes) => {
             </div>
 
             <div
-              v-if="isUIAllowed('shareView') && !isView && !isPublicView"
+              v-if="isUIAllowed('viewShare') && !isView && !isPublicView"
               v-e="['a:actions:shared-view-list']"
               class="nc-menu-item"
               @click="sharedViewListDlg = true"
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue b/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
index ff1a1d86c4..91104f45e4 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
@@ -249,7 +249,7 @@ watch(shared, () => {
 <template>
   <div>
     <a-button
-      v-if="isUIAllowed('shareView') && !isSharedBase"
+      v-if="isUIAllowed('viewShare') && !isSharedBase"
       v-e="['c:view:share']"
       outlined
       class="nc-btn-share-view nc-toolbar-btn"
diff --git a/packages/nc-gui/composables/useRoles/index.ts b/packages/nc-gui/composables/useRoles/index.ts
index 8d0370ffb5..40ad8cf3fb 100644
--- a/packages/nc-gui/composables/useRoles/index.ts
+++ b/packages/nc-gui/composables/useRoles/index.ts
@@ -1,4 +1,4 @@
-import type { Roles, RolesObj } from 'nocodb-sdk'
+import type { RolesObj } from 'nocodb-sdk'
 import { extractRolesObj } from 'nocodb-sdk'
 import { computed, createSharedComposable, useApi, useGlobal } from '#imports'
 
@@ -11,7 +11,7 @@ import { computed, createSharedComposable, useApi, useGlobal } from '#imports'
  * * `loadRoles` - a function to load reload user roles for scope
  */
 export const useRoles = createSharedComposable(() => {
-  const { user, previewAs } = useGlobal()
+  const { user } = useGlobal()
 
   const { api } = useApi()
 
diff --git a/packages/nc-gui/lib/constants.ts b/packages/nc-gui/lib/constants.ts
index 8218cc2924..9db2e733c7 100644
--- a/packages/nc-gui/lib/constants.ts
+++ b/packages/nc-gui/lib/constants.ts
@@ -73,11 +73,12 @@ const rolePermissions = {
       settingsPage: true,
       newUser: true,
       webhook: true,
-      shareView: true,
       fieldEdit: true,
       fieldAdd: true,
       tableIconEdit: true,
       viewCreateOrEdit: true,
+      viewShare: true,
+      projectShare: true,
     },
   },
   [ProjectRoles.EDITOR]: {