From 07e248dc69f004d9f15ad2c655dacf9ed29ecd83 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Sat, 17 Sep 2022 12:49:42 +0530
Subject: [PATCH] refactor(gui): move 404 page

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 packages/nc-gui/components.d.ts           | 1 +
 packages/nc-gui/composables/useProject.ts | 4 ++--
 packages/nc-gui/pages/{ => error}/404.vue | 7 +++++--
 3 files changed, 8 insertions(+), 4 deletions(-)
 rename packages/nc-gui/pages/{ => error}/404.vue (62%)

diff --git a/packages/nc-gui/components.d.ts b/packages/nc-gui/components.d.ts
index 30edfc757b..377cd11c6a 100644
--- a/packages/nc-gui/components.d.ts
+++ b/packages/nc-gui/components.d.ts
@@ -195,6 +195,7 @@ declare module '@vue/runtime-core' {
     MdiUpload: typeof import('~icons/mdi/upload')['default']
     MdiUploadOutline: typeof import('~icons/mdi/upload-outline')['default']
     MdiViewListOutline: typeof import('~icons/mdi/view-list-outline')['default']
+    MdiWarning: typeof import('~icons/mdi/warning')['default']
     MdiWhatsapp: typeof import('~icons/mdi/whatsapp')['default']
     MdiXml: typeof import('~icons/mdi/xml')['default']
     MiCircleWarning: typeof import('~icons/mi/circle-warning')['default']
diff --git a/packages/nc-gui/composables/useProject.ts b/packages/nc-gui/composables/useProject.ts
index 676a137cba..f5b728d4f0 100644
--- a/packages/nc-gui/composables/useProject.ts
+++ b/packages/nc-gui/composables/useProject.ts
@@ -109,9 +109,9 @@ const [setup, use] = useInjectionState((_projectId?: MaybeRef<string>) => {
       try {
         const baseData = await api.public.sharedBaseGet(route.params.projectId as string)
         project.value = await api.project.read(baseData.project_id!)
-      } catch (e) {
+      } catch (e: any) {
         if (e?.response?.status === 404) {
-          return router.push('/404')
+          return router.push('/error/404')
         }
         throw e
       }
diff --git a/packages/nc-gui/pages/404.vue b/packages/nc-gui/pages/error/404.vue
similarity index 62%
rename from packages/nc-gui/pages/404.vue
rename to packages/nc-gui/pages/error/404.vue
index 7197e8ef53..0948eb7d08 100644
--- a/packages/nc-gui/pages/404.vue
+++ b/packages/nc-gui/pages/error/404.vue
@@ -2,13 +2,16 @@
 import { definePageMeta } from '#imports'
 
 definePageMeta({
-  title: 'Page Not Found',
+  requiresAuth: false,
   public: true,
 })
 </script>
 
 <template>
   <div class="w-full h-[300px] flex justify-center items-center text-4xl">
-    <h1 class="text-gray-400">Page Not Found</h1>
+    <div class="text-gray-400 flex gap-2 items-center">
+      <MdiWarning />
+      Page Not Found
+    </div>
   </div>
 </template>